From: Kumar Gala <galak@kernel.crashing.org>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: linuxppc-dev list <Linuxppc-dev@ozlabs.org>,
Sergio Durigan Junior <sergiodj@br.ibm.com>,
Torez Smith <torez@us.ibm.com>,
Thiago Jung Bauermann <bauerman@br.ibm.com>,
David Gibson <dwg@au1.ibm.com>
Subject: Re: [RFC:PATCH 02/03] powerpc: Add definitions for Debug Registers on BookE Platforms
Date: Thu, 10 Dec 2009 20:41:53 -0600 [thread overview]
Message-ID: <1134F495-6623-437F-AF1F-64D0A87BA112@kernel.crashing.org> (raw)
In-Reply-To: <20091210155721.6697.40863.sendpatchset@norville.austin.ibm.com>
On Dec 10, 2009, at 9:57 AM, Dave Kleikamp wrote:
> +#define DBCR1_IAC1US 0xC0000000 /* Instr Addr Cmp 1 Sup/User =
*/
> +#define DBCR1_IAC1ER 0x30000000 /* Instr Addr Cmp 1 Eff/Real */
> +#define DBCR1_IAC1ER_01 0x10000000 /* reserved */
> +#define DBCR1_IAC1ER_10 0x20000000 /* Instr Addr Cmp 1 =
Eff/Real MSR[IS]=3D0 */
> +#define DBCR1_IAC1ER_11 0x30000000 /* Instr Addr Cmp 1 =
Eff/Real MSR[IS]=3D1 */
> +#define DBCR1_IAC2US 0x0C000000 /* Instr Addr Cmp 2 Sup/User =
*/
> +#define DBCR1_IAC2ER 0x03000000 /* Instr Addr Cmp 2 Eff/Real */
> +#define DBCR1_IAC2ER_01 0x01000000 /* reserved */
> +#define DBCR1_IAC2ER_10 0x02000000 /* Instr Addr Cmp 2 =
Eff/Real MSR[IS]=3D0 */
> +#define DBCR1_IAC2ER_11 0x03000000 /* Instr Addr Cmp 2 =
Eff/Real MSR[IS]=3D1 */
> +#define DBCR1_IAC12M 0x00C00000 /* Instr Addr 1-2 range enable =
*/
> +#define DBCR1_IAC12M_R 0x00400000 /* Instr Addr 1-2 =
reserved state */
> +#define DBCR1_IAC12M_I 0x00800000 /* Instr Addr 1-2 range =
inclusive */
> +#define DBCR1_IAC12M_X 0x00C00000 /* Instr Addr 1-2 range =
eXclusive */
> +#define DBCR1_IAC12A_T 0x00010000 /* Instr Addr 1-2 range =
Toggle */
> +#define DBCR1_IAC3US 0x0000C000 /* Instr Addr Cmp 3 Sup/User =
*/
> +#define DBCR1_IAC3ER 0x00003000 /* Instr Addr Cmp 3 Eff/Real */
> +#define DBCR1_IAC3ER_01 0x00001000 /* reserved */
> +#define DBCR1_IAC3ER_10 0x00002000 /* Instr Addr Cmp 3 =
Eff/Real MSR[IS]=3D0 */
> +#define DBCR1_IAC3ER_11 0x00003000 /* Instr Addr Cmp 3 =
Eff/Real MSR[IS]=3D1 */
> +#define DBCR1_IAC4US 0x00000C00 /* Instr Addr Cmp 4 Sup/User =
*/
> +#define DBCR1_IAC4ER 0x00000300 /* Instr Addr Cmp 4 Eff/Real */
> +#define DBCR1_IAC4ER_01 0x00000100 /* Instr Addr Cmp 4 =
Eff/Real MSR[IS]=3D0 */
> +#define DBCR1_IAC4ER_10 0x00000200 /* Instr Addr Cmp 4 =
Eff/Real MSR[IS]=3D0 */
> +#define DBCR1_IAC4ER_11 0x00000300 /* Instr Addr Cmp 4 =
Eff/Real MSR[IS]=3D1 */
> +#define DBCR1_IAC34M 0x000000C0 /* Instr Addr 3-4 range enable =
*/
> +#define DBCR1_IAC34M_R 0x00000040 /* Instr Addr 3-4 =
reserved state */
> +#define DBCR1_IAC34M_I 0x00000080 /* Instr Addr 3-4 range =
inclusive */
> +#define DBCR1_IAC34M_X 0x000000C0 /* Instr Addr 3-4 range =
eXclusive */
> +#define DBCR1_IAC34A_T 0x00000001 /* Instr Addr 3-4 range =
Toggle */
> +
> +#define DBCR1_USER_DEBUG (DBCR1_IAC12M | DBCR1_IAC34M)
> +#define DBCR1_BASE_REG_VALUE (DBCR1_IAC1US | DBCR1_IAC1ER_10 | \
> + DBCR1_IAC2US | DBCR1_IAC2ER_10 | \
> + DBCR1_IAC3US | DBCR1_IAC3ER_10 | \
> + DBCR1_IAC4US | DBCR1_IAC4ER_10)
We are we using MSR[IS] IS=3D0, why not just any Eff address? In the =
future we might have user as IS =3D 1, and kernel as IS =3D 0.
- k=
next prev parent reply other threads:[~2009-12-11 2:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 15:57 [RFC:PATCH 00/03] powerpc: Expose BookE debug registers through extended ptrace interface Dave Kleikamp
2009-12-10 15:57 ` [RFC:PATCH 01/03] powerpc: Extended " Dave Kleikamp
2009-12-11 0:44 ` David Gibson
2009-12-11 2:51 ` Kumar Gala
2009-12-10 15:57 ` [RFC:PATCH 02/03] powerpc: Add definitions for Debug Registers on BookE Platforms Dave Kleikamp
2009-12-10 17:07 ` Josh Boyer
2010-01-18 22:07 ` Dave Kleikamp
2009-12-11 0:53 ` David Gibson
2009-12-11 1:31 ` Dave Kleikamp
2010-01-18 22:10 ` Dave Kleikamp
2009-12-11 2:41 ` Kumar Gala [this message]
2009-12-11 3:28 ` David Gibson
2009-12-11 14:35 ` Kumar Gala
2009-12-14 1:16 ` David Gibson
2009-12-10 15:57 ` [RFC:PATCH 03/03] powerpc: Add support for BookE Debug Reg. traps, exceptions and ptrace Dave Kleikamp
2009-12-10 17:27 ` Josh Boyer
2009-12-10 17:41 ` Josh Boyer
2009-12-10 18:05 ` Dave Kleikamp
2009-12-11 2:50 ` Kumar Gala
2010-01-18 22:18 ` Dave Kleikamp
2009-12-11 3:26 ` David Gibson
2010-01-18 22:31 ` Dave Kleikamp
2009-12-11 2:23 ` [RFC:PATCH 00/03] powerpc: Expose BookE debug registers through extended ptrace interface Kumar Gala
2009-12-11 2:27 ` Dave Kleikamp
2009-12-11 20:07 ` Thiago Jung Bauermann
2009-12-11 20:51 ` Kumar Gala
2010-01-18 22:34 ` Dave Kleikamp
2010-02-03 2:03 ` Dave Kleikamp
2009-12-11 2:24 ` Kumar Gala
2009-12-11 2:29 ` Dave Kleikamp
2009-12-11 2:32 ` Kumar Gala
2009-12-12 4:18 ` Benjamin Herrenschmidt
2009-12-11 2:45 ` Kumar Gala
2010-01-18 22:41 ` Dave Kleikamp
-- strict thread matches above, loose matches on Subject: below --
2010-01-18 21:57 Dave Kleikamp
2010-01-18 21:59 ` [RFC:PATCH 02/03] powerpc: Add definitions for Debug Registers on BookE Platforms Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134F495-6623-437F-AF1F-64D0A87BA112@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=Linuxppc-dev@ozlabs.org \
--cc=bauerman@br.ibm.com \
--cc=dwg@au1.ibm.com \
--cc=sergiodj@br.ibm.com \
--cc=shaggy@linux.vnet.ibm.com \
--cc=torez@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).