From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Hollis Blanchard <hollis@penguinppc.org>
Cc: linuxppc64-dev <linuxppc64-dev@ozlabs.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc: Fix PowerMac sound i2c
Date: Sun, 08 Jan 2006 17:22:59 +1100 [thread overview]
Message-ID: <1136701380.30123.46.camel@localhost.localdomain> (raw)
In-Reply-To: <fe4d9bc576d696dfea0bc1b2a742307d@penguinppc.org>
On Sat, 2006-01-07 at 22:55 -0600, Hollis Blanchard wrote:
> On Jan 7, 2006, at 10:52 PM, Benjamin Herrenschmidt wrote:
>
> > + data.block[0] = len;
> > + memcpy(&data.block[1], values, len);
>
> Seem to be mixing tabs and spaces here (in both *_write_block
> functions).
You mean the patch got mangled or the code is mixing tab/spaces ? I
think the driver was pretty mixed up in the first place, I'll have to
check.
Ben.
next prev parent reply other threads:[~2006-01-08 6:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 4:52 [PATCH] powerpc: Fix PowerMac sound i2c Benjamin Herrenschmidt
2006-01-08 4:55 ` Hollis Blanchard
2006-01-08 6:22 ` Benjamin Herrenschmidt [this message]
2006-01-08 23:37 ` Benjamin Herrenschmidt
2006-01-08 10:37 ` Andreas Schwab
2006-01-08 13:30 ` Andreas Schwab
2006-01-08 21:03 ` Benjamin Herrenschmidt
2006-02-04 18:26 ` Paul Collins
2006-02-04 22:56 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1136701380.30123.46.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=hollis@penguinppc.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).