From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Benjamin Herrenschmidt To: Hollis Blanchard In-Reply-To: References: <1136695956.30123.44.camel@localhost.localdomain> Content-Type: text/plain Date: Sun, 08 Jan 2006 17:22:59 +1100 Message-Id: <1136701380.30123.46.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc64-dev , linuxppc-dev list Subject: Re: [PATCH] powerpc: Fix PowerMac sound i2c List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 2006-01-07 at 22:55 -0600, Hollis Blanchard wrote: > On Jan 7, 2006, at 10:52 PM, Benjamin Herrenschmidt wrote: > > > + data.block[0] = len; > > + memcpy(&data.block[1], values, len); > > Seem to be mixing tabs and spaces here (in both *_write_block > functions). You mean the patch got mangled or the code is mixing tab/spaces ? I think the driver was pretty mixed up in the first place, I'll have to check. Ben.