From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, Cedric Pradalier <cedric.pradalier@free.fr>
Subject: Re: Fw: therm_adm103x: inquiry
Date: Fri, 13 Jan 2006 21:35:36 +1100 [thread overview]
Message-ID: <1137148536.4862.7.camel@localhost.localdomain> (raw)
In-Reply-To: <17351.28085.401798.395945@cargo.ozlabs.ibm.com>
On Fri, 2006-01-13 at 20:07 +1100, Paul Mackerras wrote:
> Cedric Pradalier writes:
>
> > As far as I can see, this module seems mature enough for
> > inclusion in official kernel.
> >
> > A tested patch against 2.6.14 is available at:
> > http://cedric.pradalier.free.fr/ibook2/adm103x-2.6.14.diff.gz
> >
> > I've not tested it yet for 2.6.15.
> >
> > Some details, from the link site above:
> >
> > The module provides and sysfs access to the adm103x fan
> > control parameters. For instance
> >
> > #cat /sys/device/temperatures/info?
> > T:51°C S:56°C R:10°C <-- sensor 0
> > T:48°C S:76°C R:10°C <-- sensor 1
>
> I think we should remove the degree symbol, since it is neither ASCII
> nor UTF-8, and it is unnecessary. Apart from that it sounds OK; we
> would have to see the code before deciding whether to include it.
Cedric, you should post the patch directly inline with the mail, with
the proper description and Signed-off-by line.
Ben.
prev parent reply other threads:[~2006-01-13 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 11:52 Fw: therm_adm103x: inquiry Cedric Pradalier
2006-01-13 9:07 ` Paul Mackerras
2006-01-13 10:35 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137148536.4862.7.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=cedric.pradalier@free.fr \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).