Fw: therm_adm103x: inquiry

Fw: therm_adm103x: inquiry

[Cedric Pradalier]

Begin forwarded message:

Date: Thu, 12 Jan 2006 21:34:14 +1100
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Cedric Pradalier <cedric.pradalier@free.fr>
Subject: Re: therm_adm103x: inquiry


>
>> So practically, what should I do? What should I sent to who?
>
>linuxppc-dev@ozlabs.org CC me & paulus :)
>
>Ben.
>
>

Hi

I'm the author of the therm_adm103x module, used to control
and display the fan management information on ibook G3, rev
2.2 (at least), available since 2.6.4.

Currently, the module is available as a patch or as a
binary module linked with current debian testing kernel:
http://cedric.pradalier.free.fr/ibook2

As far as I can see, this module seems mature enough for
inclusion in official kernel.

A tested patch against 2.6.14 is available at:
http://cedric.pradalier.free.fr/ibook2/adm103x-2.6.14.diff.gz

I've not tested it yet for 2.6.15. 

Some details, from the link site above:

The module provides and sysfs access to the adm103x fan
control parameters. For instance

	  #cat /sys/device/temperatures/info? 
	  T:51°C S:56°C R:10°C  <-- sensor 0
	  T:48°C S:76°C R:10°C  <-- sensor 1
	  #echo "56 10" > /sys/device/temperatures/info0 

make the fan starts at 56 degrees and accelerate
progressively till max at 66 degrees (56 + 10), on the
sensor 0.

To see if thermal control is done by the chips that this
module can manage, just check that
	#cat /proc/device-tree/uni-n/i2c/fan/device_type
returns adm1030 or adm1031.

-- 
Cedric

Re: Fw: therm_adm103x: inquiry

[Paul Mackerras]

Cedric Pradalier writes:

> As far as I can see, this module seems mature enough for
> inclusion in official kernel.
>=20
> A tested patch against 2.6.14 is available at:
> http://cedric.pradalier.free.fr/ibook2/adm103x-2.6.14.diff.gz
>=20
> I've not tested it yet for 2.6.15.=20
>=20
> Some details, from the link site above:
>=20
> The module provides and sysfs access to the adm103x fan
> control parameters. For instance
>=20
> =09  #cat /sys/device/temperatures/info=3F=20
> =09  T:51=B0C S:56=B0C R:10=B0C  <-- sensor 0
> =09  T:48=B0C S:76=B0C R:10=B0C  <-- sensor 1

I think we should remove the degree symbol, since it is neither ASCII
nor UTF-8, and it is unnecessary.  Apart from that it sounds OK; we
would have to see the code before deciding whether to include it.

Paul.

Re: Fw: therm_adm103x: inquiry

[Benjamin Herrenschmidt]

On Fri, 2006-01-13 at 20:07 +1100, Paul Mackerras wrote:
> Cedric Pradalier writes:
> 
> > As far as I can see, this module seems mature enough for
> > inclusion in official kernel.
> > 
> > A tested patch against 2.6.14 is available at:
> > http://cedric.pradalier.free.fr/ibook2/adm103x-2.6.14.diff.gz
> > 
> > I've not tested it yet for 2.6.15. 
> > 
> > Some details, from the link site above:
> > 
> > The module provides and sysfs access to the adm103x fan
> > control parameters. For instance
> > 
> > 	  #cat /sys/device/temperatures/info? 
> > 	  T:51°C S:56°C R:10°C  <-- sensor 0
> > 	  T:48°C S:76°C R:10°C  <-- sensor 1
> 
> I think we should remove the degree symbol, since it is neither ASCII
> nor UTF-8, and it is unnecessary.  Apart from that it sounds OK; we
> would have to see the code before deciding whether to include it.

Cedric, you should post the patch directly inline with the mail, with
the proper description and Signed-off-by line.

Ben.