* [RFC][Patch] pci_0 pci_1 mixup in ppc/platforms/chestnut.c
@ 2006-01-19 13:59 Eric Sesterhenn / snakebyte
2006-01-19 18:29 ` Mark A. Greer
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sesterhenn / snakebyte @ 2006-01-19 13:59 UTC (permalink / raw)
To: linuxppc-dev
hi,
i am currently toying around with cp-miner
( http://opera.cs.uiuc.edu/Projects/ARTS/CP-Miner.htm )
and came across chesnut.c
/* setup only PCI bus 0 (bus 1 not used) */
si.pci_0.enable_bus = 1;
si.pci_0.pci_io.cpu_base = CHESTNUT_PCI0_IO_PROC_ADDR;
si.pci_0.pci_io.pci_base_hi = 0;
si.pci_0.pci_io.pci_base_lo = CHESTNUT_PCI0_IO_PCI_ADDR;
si.pci_0.pci_io.size = CHESTNUT_PCI0_IO_SIZE;
[...SNIP ... ]
si.pci_1.acc_cntl_options[i] =
MV64360_PCI_ACC_CNTL_SNOOP_NONE |
MV64360_PCI_ACC_CNTL_SWAP_NONE |
[...]
since the commentary clearly states that only pci_0 is
used i assume this is a bug and the si.pci_0.acc_cntl_options
should be set?
Please cc me on replies since i am not subscribed.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.15-git11/arch/ppc/platforms/chestnut.c.orig 2006-01-19 14:54:59.000000000 +0100
+++ linux-2.6.15-git11/arch/ppc/platforms/chestnut.c 2006-01-19 14:55:25.000000000 +0100
@@ -199,7 +199,7 @@ chestnut_setup_bridge(void)
si.mpsc_options[i] = MV64360_MPSC2MEM_SNOOP_NONE;
si.idma_options[i] = MV64360_IDMA2MEM_SNOOP_NONE;
- si.pci_1.acc_cntl_options[i] =
+ si.pci_0.acc_cntl_options[i] =
MV64360_PCI_ACC_CNTL_SNOOP_NONE |
MV64360_PCI_ACC_CNTL_SWAP_NONE |
MV64360_PCI_ACC_CNTL_MBURST_128_BYTES |
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC][Patch] pci_0 pci_1 mixup in ppc/platforms/chestnut.c
2006-01-19 13:59 [RFC][Patch] pci_0 pci_1 mixup in ppc/platforms/chestnut.c Eric Sesterhenn / snakebyte
@ 2006-01-19 18:29 ` Mark A. Greer
0 siblings, 0 replies; 2+ messages in thread
From: Mark A. Greer @ 2006-01-19 18:29 UTC (permalink / raw)
To: Eric Sesterhenn / snakebyte; +Cc: linuxppc-dev
On Thu, Jan 19, 2006 at 02:59:19PM +0100, Eric Sesterhenn / snakebyte wrote:
<snip>
> --- linux-2.6.15-git11/arch/ppc/platforms/chestnut.c.orig 2006-01-19 14:54:59.000000000 +0100
> +++ linux-2.6.15-git11/arch/ppc/platforms/chestnut.c 2006-01-19 14:55:25.000000000 +0100
> @@ -199,7 +199,7 @@ chestnut_setup_bridge(void)
> si.mpsc_options[i] = MV64360_MPSC2MEM_SNOOP_NONE;
> si.idma_options[i] = MV64360_IDMA2MEM_SNOOP_NONE;
>
> - si.pci_1.acc_cntl_options[i] =
> + si.pci_0.acc_cntl_options[i] =
> MV64360_PCI_ACC_CNTL_SNOOP_NONE |
> MV64360_PCI_ACC_CNTL_SWAP_NONE |
> MV64360_PCI_ACC_CNTL_MBURST_128_BYTES |
>
Good catch. Note that the tree you should be submitting patches against
is the powerpc.git tree. In this case, though, I expect the patch to apply
cleanly to that tree.
Also, there are 2 place where that occurs. Mind fixing both?
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-19 18:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-19 13:59 [RFC][Patch] pci_0 pci_1 mixup in ppc/platforms/chestnut.c Eric Sesterhenn / snakebyte
2006-01-19 18:29 ` Mark A. Greer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).