From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Collins <paul@briny.ondioline.org>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc: Fix PowerMac sound i2c
Date: Sun, 05 Feb 2006 09:56:02 +1100 [thread overview]
Message-ID: <1139093763.5634.3.camel@localhost.localdomain> (raw)
In-Reply-To: <87y80rkmk7.fsf@briny.internal.ondioline.org>
On Sat, 2006-02-04 at 18:26 +0000, Paul Collins wrote:
> Hi Ben,
>
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>
> > My patch reworking the PowerMac i2c code break the sound drivers as they
> > used to rely on some broken behaviour of i2c-keywest that is gone now.
> > This patch should fix them (tested on a g5 with alsa only). It might
> > also fix an oops if the alsa driver hits an unsupported chip.
>
> Applied Linus's current git tree, this patch makes ALSA sound on my
> PowerBook5,4 work again. The second patch does not work because the
> i2c wrapper (I assume that's what i2c_smbus_write_i2c_block_data is)
> has apparently not yet returned.
>
> It would be nice to have this fix in 2.6.16 if possible.
The second patch is the one that should go in, but it relies on an i2c
fix (undoing some Bunk damage) that is still staging in Greg tree... I
don't know what's up with that, I'll ask around.
Ben.
prev parent reply other threads:[~2006-02-04 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 4:52 [PATCH] powerpc: Fix PowerMac sound i2c Benjamin Herrenschmidt
2006-01-08 4:55 ` Hollis Blanchard
2006-01-08 6:22 ` Benjamin Herrenschmidt
2006-01-08 23:37 ` Benjamin Herrenschmidt
2006-01-08 10:37 ` Andreas Schwab
2006-01-08 13:30 ` Andreas Schwab
2006-01-08 21:03 ` Benjamin Herrenschmidt
2006-02-04 18:26 ` Paul Collins
2006-02-04 22:56 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139093763.5634.3.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paul@briny.ondioline.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).