From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] powerpc: Thermal control for dual core G5s From: Benjamin Herrenschmidt To: Linus Torvalds In-Reply-To: References: <1139377372.8187.16.camel@localhost.localdomain> Content-Type: text/plain Date: Wed, 08 Feb 2006 17:38:51 +1100 Message-Id: <1139380731.5003.1.camel@localhost.localdomain> Mime-Version: 1.0 Cc: Andrew Morton , linuxppc-dev list , linuxppc64-dev List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2006-02-07 at 22:07 -0800, Linus Torvalds wrote: > > On Wed, 8 Feb 2006, Benjamin Herrenschmidt wrote: > > > > This patch adds a windfarm module, windfarm_pm112, for the dual core G5s > > (both 2 and 4 core models), keeping the machine from getting into > > vacuum-cleaner mode ;) > > This seems to introduce a new warning.. > > arch/powerpc/platforms/83xx/Kconfig:10: > warning: 'select' used by config symbol 'MPC834x_SYS' refer to undefined symbol 'DEFAULT_UIMAGE' Former is not mine... > drivers/macintosh/Kconfig:193: > warning: 'select' used by config symbol 'WINDFARM_PM112' refer to undefined symbol 'I2C_PMAC_SMU' Ok, looks like I forgot to update the Kconfig for the new i2c driver, it should select I2C_POWERMAC instead. Do you want a new patch or can you just fix it there ? Ben.