From: John Rose <johnrose@austin.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: External List <linuxppc-dev@ozlabs.org>
Subject: Re: pci_dlpar.c & probe mode
Date: Fri, 24 Mar 2006 10:16:45 -0600 [thread overview]
Message-ID: <1143217005.2567.12.camel@sinatra.austin.ibm.com> (raw)
In-Reply-To: <1143160576.4257.51.camel@localhost.localdomain>
> I noticed that pcibios_add_pci_devices() test the platform type to
> decide wether to do a device-tree based probe or a direct PCI probe. Why
> can't it use ppc_md.probe_mode() like the rest of the PCI code does ?
I can't see a good reason either! :) I'll have a patch in two shakes of
a lamb's tail.
On a related note, I don't understand why devtree-based probe is only
desirable for the LPAR case (on pSeries).
Also, do we anticipate future probe modes for new platforms or
something? Adding such logic to ppc_md seems like mucho infrastructure
to answer a simple question (lpar or not). For exmaple, _machine gets
used all over the pmac code.
John
next prev parent reply other threads:[~2006-03-24 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 0:36 pci_dlpar.c & probe mode Benjamin Herrenschmidt
2006-03-24 16:16 ` John Rose [this message]
2006-03-24 21:48 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1143217005.2567.12.camel@sinatra.austin.ibm.com \
--to=johnrose@austin.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).