linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jake Moilanen <moilanen@austin.ibm.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 2/2] Base pSeries PCIe support
Date: Wed, 12 Apr 2006 07:31:06 +1000	[thread overview]
Message-ID: <1144791067.19353.46.camel@localhost.localdomain> (raw)
In-Reply-To: <20060410103929.9664238d.moilanen@austin.ibm.com>


> I was able to validate that these patches do work, and we are receiving
> MSI interrupts correctly.
> 
> Is it too late to get into 2.6.17?

Yes and it's totally broken anyway. The whole idea of "hiding" MSIs as
if they were LSIs is totally irrealistic in practice. Our firmware might
do it but we have to undo it.

Linux defines the semantics of a driver probe() routine to be called
with MSIs disabled by default.

This is very important as for a lot of devices (I'd say the vast
majority of the devices that claim to be MSI capable), enabling MSI is
either broken (various HW bugs related to using them, mostly ordering
issues) or requires all sort of additional tweaking on the device side
in addition to the standard config space stuffs.

Thus, we need to help whoever is currently ripping off the
drivers/pci/msi.c code which is way too Intel-centric (there's an SGI
guy working on it already) and implement an arch specific implementation
that undoes what the firmware did, and then re-assign MSIs as requested
by drviers.

Some of the Boeblingen folks have already been looking into it as part
of some bare-metal/bringup effort, but that doesn't include PAPR
implementation.

Ben.

  reply	other threads:[~2006-04-11 21:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-31 22:02 [PATCH 0/2] Base pSeries PCIe support Jake Moilanen
2006-03-31 22:05 ` [PATCH 1/2] " Jake Moilanen
2006-03-31 22:15   ` Dave Hansen
2006-03-31 22:18     ` Jake Moilanen
2006-04-12  4:06   ` Christoph Hellwig
2006-03-31 22:13 ` [PATCH 2/2] " Jake Moilanen
2006-03-31 22:48   ` Olof Johansson
2006-03-31 23:08     ` Olof Johansson
2006-04-01  8:36   ` Paul Mackerras
2006-04-01 22:57     ` Jake Moilanen
2006-04-10 15:39       ` Jake Moilanen
2006-04-11 21:31         ` Benjamin Herrenschmidt [this message]
2006-04-01  8:38   ` Paul Mackerras
2006-04-12  4:05   ` Christoph Hellwig
2006-03-31 22:28 ` [PATCH 0/2] " Arnd Bergmann
2006-03-31 22:35   ` Jake Moilanen
2006-03-31 22:39 ` Doug Maxey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1144791067.19353.46.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=moilanen@austin.ibm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).