LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Collins <paul@briny.ondioline.org>
Cc: "\[ATR\]Dj-Death" <djdeath@gmx.fr>,
	linuxppc-dev@ozlabs.org,
	Michael Schmitz <schmitz@zirkon.biophys.uni-duesseldorf.de>,
	debian-powerpc@lists.debian.org,
	Paul Mackerras <paulus@samba.org>
Subject: Re: 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5,4 -- no sound?")
Date: Wed, 19 Apr 2006 15:19:22 +1000	[thread overview]
Message-ID: <1145423962.9924.40.camel@localhost.localdomain> (raw)
In-Reply-To: <87r73u19b1.fsf@briny.internal.ondioline.org>


>   arch/powerpc/platforms/powermac/setup.c:721: error: 'mach_powermac' undeclared here (not in a function)
>   arch/powerpc/platforms/powermac/setup.c:721: warning: type defaults to 'int' in declaration of 'mach_powermac'
>   make[2]: *** [arch/powerpc/platforms/powermac/setup.o] Error 1
>   make[1]: *** [arch/powerpc/platforms/powermac] Error 2
>   make: *** [arch/powerpc/platforms] Error 2
> 
> It looks like the EXPORT_SYMBOL() needs to be after the definition.
> 
> However, I tried adding "EXPORT_SYMBOL(mach_powermac);" after the
> define_machine(powermac) and now sound works for me with my original
> I2C_POWERMAC=y SND_POWERMAC=m configuration.

Yup, Paul has a working patch already, will be in 2.6.17 soonish. 

Cheers,
Ben.

  reply	other threads:[~2006-04-19  5:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.44.0604181714400.12545-100000@zirkon.biophys.uni-duesseldorf.de>
     [not found] ` <1145397523.4705.94.camel@localhost.localdomain>
2006-04-19  4:25   ` 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5, 4 -- no sound?") Paul Collins
2006-04-19  5:19     ` Benjamin Herrenschmidt [this message]
2006-04-20 13:51       ` 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5,4 " Michael Schmitz
2006-04-20 20:48         ` Benjamin Herrenschmidt
2006-04-21  7:22           ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1145423962.9924.40.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=debian-powerpc@lists.debian.org \
    --cc=djdeath@gmx.fr \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paul@briny.ondioline.org \
    --cc=paulus@samba.org \
    --cc=schmitz@zirkon.biophys.uni-duesseldorf.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox