* Re: 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5, 4 -- no sound?") [not found] ` <1145397523.4705.94.camel@localhost.localdomain> @ 2006-04-19 4:25 ` Paul Collins 2006-04-19 5:19 ` 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5,4 " Benjamin Herrenschmidt 0 siblings, 1 reply; 5+ messages in thread From: Paul Collins @ 2006-04-19 4:25 UTC (permalink / raw) To: Benjamin Herrenschmidt Cc: [ATR]Dj-Death, linuxppc-dev, Michael Schmitz, debian-powerpc, Paul Mackerras Hi Ben, Benjamin Herrenschmidt <benh@kernel.crashing.org> writes: > On Tue, 2006-04-18 at 17:20 +0200, Michael Schmitz wrote: >> > > Here a trace at boot from the sound driver : >> > >> > I think that bug happens if the sound driver loads before i2c-powermac. >> >> i2c-keywest is still request-module()d in 2.6.17-rc1, FWIW. >> >> Regarding other sound breakage with 2.6.17-rc1, I traced that to >> >> machine_is(powermac) >> >> returning zero in sound/ppc/pmac.c:snd_pmac_detect() when loading >> snd-powermac. The OSS driver spits -ENODEV as well on loading so I'd >> suspect the same thing here. >> >> machine_is boils down to a comparison machine_id == &mach_powermac, is >> that sort of thing illegal after kernel init? > > Totally untested patch, please let me know if it helps: Results in the following. arch/powerpc/platforms/powermac/setup.c:721: error: 'mach_powermac' undeclared here (not in a function) arch/powerpc/platforms/powermac/setup.c:721: warning: type defaults to 'int' in declaration of 'mach_powermac' make[2]: *** [arch/powerpc/platforms/powermac/setup.o] Error 1 make[1]: *** [arch/powerpc/platforms/powermac] Error 2 make: *** [arch/powerpc/platforms] Error 2 It looks like the EXPORT_SYMBOL() needs to be after the definition. However, I tried adding "EXPORT_SYMBOL(mach_powermac);" after the define_machine(powermac) and now sound works for me with my original I2C_POWERMAC=y SND_POWERMAC=m configuration. -- Dag vijandelijk luchtschip de huismeester is dood ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5,4 -- no sound?") 2006-04-19 4:25 ` 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5, 4 -- no sound?") Paul Collins @ 2006-04-19 5:19 ` Benjamin Herrenschmidt 2006-04-20 13:51 ` Michael Schmitz 0 siblings, 1 reply; 5+ messages in thread From: Benjamin Herrenschmidt @ 2006-04-19 5:19 UTC (permalink / raw) To: Paul Collins Cc: [ATR]Dj-Death, linuxppc-dev, Michael Schmitz, debian-powerpc, Paul Mackerras > arch/powerpc/platforms/powermac/setup.c:721: error: 'mach_powermac' undeclared here (not in a function) > arch/powerpc/platforms/powermac/setup.c:721: warning: type defaults to 'int' in declaration of 'mach_powermac' > make[2]: *** [arch/powerpc/platforms/powermac/setup.o] Error 1 > make[1]: *** [arch/powerpc/platforms/powermac] Error 2 > make: *** [arch/powerpc/platforms] Error 2 > > It looks like the EXPORT_SYMBOL() needs to be after the definition. > > However, I tried adding "EXPORT_SYMBOL(mach_powermac);" after the > define_machine(powermac) and now sound works for me with my original > I2C_POWERMAC=y SND_POWERMAC=m configuration. Yup, Paul has a working patch already, will be in 2.6.17 soonish. Cheers, Ben. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5,4 -- no sound?") 2006-04-19 5:19 ` 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5,4 " Benjamin Herrenschmidt @ 2006-04-20 13:51 ` Michael Schmitz 2006-04-20 20:48 ` Benjamin Herrenschmidt 0 siblings, 1 reply; 5+ messages in thread From: Michael Schmitz @ 2006-04-20 13:51 UTC (permalink / raw) To: Benjamin Herrenschmidt Cc: [ATR]Dj-Death, linuxppc-dev, debian-powerpc, Paul Mackerras > > arch/powerpc/platforms/powermac/setup.c:721: error: 'mach_powermac' undeclared here (not in a function) > > arch/powerpc/platforms/powermac/setup.c:721: warning: type defaults to 'int' in declaration of 'mach_powermac' > > make[2]: *** [arch/powerpc/platforms/powermac/setup.o] Error 1 > > make[1]: *** [arch/powerpc/platforms/powermac] Error 2 > > make: *** [arch/powerpc/platforms] Error 2 That's how far I got on my own (didn't try Bens patch yet but machine_id is in fact still OK in the module, so exporting the necessary bits should fix it. Commenting out the -ENODEV return gives me working sound; didn't I mention that? > > However, I tried adding "EXPORT_SYMBOL(mach_powermac);" after the > > define_machine(powermac) and now sound works for me with my original > > I2C_POWERMAC=y SND_POWERMAC=m configuration. > > Yup, Paul has a working patch already, will be in 2.6.17 soonish. I'll pull the current tree as soon as I'm back at the lab. Michael ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5,4 -- no sound?") 2006-04-20 13:51 ` Michael Schmitz @ 2006-04-20 20:48 ` Benjamin Herrenschmidt 2006-04-21 7:22 ` Michael Schmitz 0 siblings, 1 reply; 5+ messages in thread From: Benjamin Herrenschmidt @ 2006-04-20 20:48 UTC (permalink / raw) To: Michael Schmitz Cc: [ATR]Dj-Death, linuxppc-dev, debian-powerpc, Paul Mackerras On Thu, 2006-04-20 at 15:51 +0200, Michael Schmitz wrote: > > > arch/powerpc/platforms/powermac/setup.c:721: error: 'mach_powermac' undeclared here (not in a function) > > > arch/powerpc/platforms/powermac/setup.c:721: warning: type defaults to 'int' in declaration of 'mach_powermac' > > > make[2]: *** [arch/powerpc/platforms/powermac/setup.o] Error 1 > > > make[1]: *** [arch/powerpc/platforms/powermac] Error 2 > > > make: *** [arch/powerpc/platforms] Error 2 > > That's how far I got on my own (didn't try Bens patch yet but machine_id > is in fact still OK in the module, so exporting the necessary bits should > fix it. > > Commenting out the -ENODEV return gives me working sound; didn't I mention > that? There is a proper patch in paulus tree.. it's basically the patch I posted with an extern declaration at the beginning of the macro before the EXPORT_SYMBOL. > > > However, I tried adding "EXPORT_SYMBOL(mach_powermac);" after the > > > define_machine(powermac) and now sound works for me with my original > > > I2C_POWERMAC=y SND_POWERMAC=m configuration. > > > > Yup, Paul has a working patch already, will be in 2.6.17 soonish. > > I'll pull the current tree as soon as I'm back at the lab. Patch isn't in yet it seems. Ben ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5,4 -- no sound?") 2006-04-20 20:48 ` Benjamin Herrenschmidt @ 2006-04-21 7:22 ` Michael Schmitz 0 siblings, 0 replies; 5+ messages in thread From: Michael Schmitz @ 2006-04-21 7:22 UTC (permalink / raw) To: Benjamin Herrenschmidt Cc: [ATR]Dj-Death, linuxppc-dev, debian-powerpc, Paul Mackerras > > Commenting out the -ENODEV return gives me working sound; didn't I mention > > that? > > There is a proper patch in paulus tree.. it's basically the patch I > posted with an extern declaration at the beginning of the macro before > the EXPORT_SYMBOL. Yep, I got that right; just wanted to report that this is the only problem with sound I have in 2.6.17 (well, sound dies after changing the volume with gtkpbbuttons while playing something in VLC, but that's not necessarily 2.6.17 specific. Need to try 2.6.16 with that). > Patch isn't in yet it seems. No sweat - seems I'll need a bigger disk anyway before pulling another update :-) Michael ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-04-21 7:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Pine.LNX.4.44.0604181714400.12545-100000@zirkon.biophys.uni-duesseldorf.de>
[not found] ` <1145397523.4705.94.camel@localhost.localdomain>
2006-04-19 4:25 ` 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5, 4 -- no sound?") Paul Collins
2006-04-19 5:19 ` 2.6.16 backtrace at boot (Ibook G4) (related to "PowerBook5,4 " Benjamin Herrenschmidt
2006-04-20 13:51 ` Michael Schmitz
2006-04-20 20:48 ` Benjamin Herrenschmidt
2006-04-21 7:22 ` Michael Schmitz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).