From: Michael Ellerman <michael@ellerman.id.au>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: [RFC/PATCH 0/4] powerpc: Use pr_debug() for debugging
Date: Mon, 01 May 2006 10:53:41 +1000 [thread overview]
Message-ID: <1146444821.660434.518701003988.qpush@concordia> (raw)
Currently we have a macro called DBG() defined in most files in arch/powerpc,
which is used to do debugging printks.
In some files DBG evaluates to printk() and in others it becomes udbg_printf(),
but there doesn't seem to be any logic to explain why it's one or the other.
In fact in some files it'd be nice if it was both, so you could have early
debugging (udbg_printf), but then have things hit the dmesg buffer later (via
printk).
Using udbg_printf() in general is suboptimal IMHO because it bypasses the
printk buffer, so if you miss the messages on the screen you can't go back and
see them in dmesg.
So this series of patches rejiggers things so that we register the udbg
console really early, and therefore can always use printk. It then goes on to
change all the home spun DBG() macros into pr_debug() calls, from
include/linux/kernel.h
I haven't tested this extensively because I wanted to gauge people's reaction
first. It "works" on pSeries LPAR, and iSeries, but I haven't tested on 32-bit,
and I don't know that code well so I'm all ears on that.
cheers
next reply other threads:[~2006-05-01 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-01 0:53 Michael Ellerman [this message]
2006-05-01 0:53 ` [RFC/PATCH 1/4] powerpc: Register udbg_console for early debugging Michael Ellerman
2006-05-01 0:53 ` [RFC/PATCH 2/4] powerpc: Convert DBG to pr_debug in arch/powerpc/kernel Michael Ellerman
2006-05-01 0:53 ` [RFC/PATCH 3/4] powerpc: Convert DBG to pr_debug in arch/powerpc/platforms Michael Ellerman
2006-05-01 0:53 ` [RFC/PATCH 4/4] powerpc: Convert DBG to pr_debug for the rest of arch/powerpc Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146444821.660434.518701003988.qpush@concordia \
--to=michael@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox