From: Michael Ellerman <michael@ellerman.id.au>
To: Ryan Arnold <rsa@us.ibm.com>
Cc: linuxppc-dev@ozlabs.org, cbe-oss-dev@ozlabs.org,
	Milton Miller <miltonm@bga.com>
Subject: Re: question on why hvc_console calls hvc_poll() in hvc_handle_interrupt().
Date: Wed, 03 May 2006 17:42:43 +1000	[thread overview]
Message-ID: <1146642164.16640.30.camel@localhost.localdomain> (raw)
In-Reply-To: <1145564752.29313.185.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On Thu, 2006-04-20 at 15:25 -0500, Ryan Arnold wrote:
> While on the topic of hvc_console; I think I saw a patch go through a
> while ago that added hvc_poll() to hvc_handle_interrupt().  I can't say
> I'm too pleased with that addition.  I did my best to keep locking
> outside of the interrupt handler.
> 
> I wonder if that change was tested on a power5 lpar system with several
> secondary VSerial Server adapters (hvc1-hvcn) being hammered with data.
> I'm pretty paranoid about deadlock, hence the reason for keeping locking
> out of the int. handler.
That was Milton's patch. No idea whether it's correct/tested.
cheers
-- 
Michael Ellerman
IBM OzLabs
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]
     prev parent reply	other threads:[~2006-05-03  7:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-18 18:55 [PATCH] powerpc: Make rtas console _much_ faster Michael Ellerman
2006-04-18 19:30 ` Olof Johansson
2006-04-20 20:03 ` Ryan Arnold
2006-04-20 20:25   ` question on why hvc_console calls hvc_poll() in hvc_handle_interrupt() Ryan Arnold
2006-05-03  7:42     ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=1146642164.16640.30.camel@localhost.localdomain \
    --to=michael@ellerman.id.au \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=miltonm@bga.com \
    --cc=rsa@us.ibm.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).