From: Eric Paris <eparis@redhat.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: discuss@x86-64.org, linux-kernel@vger.kernel.org,
wli@holomorphy.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Fix do_mlock so page alignment is to hugepage boundries when needed
Date: Wed, 17 May 2006 14:20:53 -0400 [thread overview]
Message-ID: <1147890053.26468.22.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0605171020390.13767@schroedinger.engr.sgi.com>
On Wed, 2006-05-17 at 10:24 -0700, Christoph Lameter wrote:
> On Wed, 17 May 2006, Eric Paris wrote:
>
> > --- linux-2.6.16.14/include/asm-sparc64/page.h.paris
> > +++ linux-2.6.16.14/include/asm-sparc64/page.h
> > @@ -104,6 +104,8 @@ typedef unsigned long pgprot_t;
> > #define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT)
> > #define ARCH_HAS_SETCLEAR_HUGE_PTE
> > #define ARCH_HAS_HUGETLB_PREFAULT_HOOK
> > +/* to align the pointer to the (next) page boundary when dealing with hugepages*/
> > +#define HPAGE_ALIGN(addr) (((addr)+HPAGE_SIZE-1)&HPAGE_MASK)
> > #endif
>
> Could you put the definition of HPAGE_ALIGN into include/linux/hugetlb.h
> to avoid modifying all the page.h files?
I could, I was just following the example of PAGE_ALIGN which was in all
the page.h files. But since it really is a nonarch specific hugepage
only macro maybe that is a better place for it.
If other results come back positive I'll repost with that change if
others think it best.
-Eric
next prev parent reply other threads:[~2006-05-17 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 17:01 [PATCH] Fix do_mlock so page alignment is to hugepage boundries when needed Eric Paris
2006-05-17 17:24 ` Christoph Lameter
2006-05-17 18:20 ` Eric Paris [this message]
2006-05-17 17:42 ` Hugh Dickins
2006-05-17 19:59 ` Eric Paris
2006-05-18 11:13 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147890053.26468.22.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=clameter@sgi.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).