Re: [PATCH][resend] udbg_printf() formatting attribute

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2122 bytes --]

On Wed, 2006-05-17 at 12:00 -0400, jimix@watson.ibm.com wrote:
> Sorry, Previous patch was munged by MTA.
> 
> This patch allows the compiler to catch any printf-like mismatches for
> udbg_printf().  After some brute force building I've only found issues
> with my own code and lparcfg.c It could break some developers, but
> IMHO that would be goodness.
> 
> Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com>
> 
> ---
> 
> diff -r 0163968f7fce arch/powerpc/kernel/lparcfg.c
> --- a/arch/powerpc/kernel/lparcfg.c	Tue May 16 15:55:19 2006 -0400
> +++ b/arch/powerpc/kernel/lparcfg.c	Wed May 17 11:55:21 2006 -0400
> @@ -521,10 +521,10 @@ static ssize_t lparcfg_write(struct file
>  
>  	current_weight = (resource >> 5 * 8) & 0xFF;
>  
> -	pr_debug("%s: current_entitled = %lu, current_weight = %lu\n",
> +	pr_debug("%s: current_entitled = %lu, current_weight = %u\n",
>  		 __FUNCTION__, current_entitled, current_weight);
>  
> -	pr_debug("%s: new_entitled = %lu, new_weight = %lu\n",
> +	pr_debug("%s: new_entitled = %lu, new_weight = %u\n",
>  		 __FUNCTION__, *new_entitled_ptr, *new_weight_ptr);

But pr_debug() calls printk, not udbg_printf() ?

cheers

>  
>  	retval = plpar_hcall_norets(H_SET_PPP, *new_entitled_ptr,
> diff -r 0163968f7fce include/asm-powerpc/udbg.h
> --- a/include/asm-powerpc/udbg.h	Tue May 16 15:55:19 2006 -0400
> +++ b/include/asm-powerpc/udbg.h	Wed May 17 11:55:21 2006 -0400
> @@ -23,7 +23,8 @@ extern int udbg_read(char *buf, int bufl
>  extern int udbg_read(char *buf, int buflen);
>  
>  extern void register_early_udbg_console(void);
> -extern void udbg_printf(const char *fmt, ...);
> +extern void udbg_printf(const char *fmt, ...)
> +	__attribute__ ((format (printf, 1, 2)));
>  extern void udbg_progress(char *s, unsigned short hex);
>  
>  extern void udbg_init_uart(void __iomem *comport, unsigned int speed,

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]