From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Alexandre.Bounine@tundra.com,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
Yang Xin-Xin-r48390 <Xin-Xin.Yang@freescale.com>
Subject: Re: [PATCH/2.6.17-rc4 1/10] Powerpc: Add general support for mpc7448h pc2 (Taiga) platform
Date: Thu, 18 May 2006 10:41:07 +1000 [thread overview]
Message-ID: <1147912867.10703.42.camel@localhost.localdomain> (raw)
In-Reply-To: <AF039DA5-BAED-4646-904A-18BE025989AD@kernel.crashing.org>
On Wed, 2006-05-17 at 08:45 -0500, Kumar Gala wrote:
> > +#ifdef TSI108_ETH
> > +hw_info hw_info_table[TSI108_ETH_MAX_PORTS + 1] = {
> > + {TSI108_CSR_ADDR_PHYS + TSI108_ETH_OFFSET,
> > + TSI108_CSR_ADDR_PHYS + TSI108_ETH_OFFSET,
> > + TSI108_PHY0_ADDR, IRQ_TSI108_GIGE0},
> > +
> > + {TSI108_CSR_ADDR_PHYS + TSI108_ETH_OFFSET + 0x400,
> > + TSI108_CSR_ADDR_PHYS + TSI108_ETH_OFFSET,
> > + TSI108_PHY1_ADDR, IRQ_TSI108_GIGE1},
> > +
> > + {TBL_END, TBL_END, TBL_END, TBL_END}
> > +};
> > +#endif
>
> This table looks problematic. Look at using something like a
> platform device.
Bzzzt ... wrong answer :) That's a textbook example of stuff that should
be provided via the device-tree.
next prev parent reply other threads:[~2006-05-18 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 10:13 [PATCH/2.6.17-rc4 1/10] Powerpc: Add general support for mpc7448h pc2 (Taiga) platform Zang Roy-r61911
2006-05-17 13:45 ` Kumar Gala
2006-05-18 0:41 ` Benjamin Herrenschmidt [this message]
2006-05-18 0:47 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147912867.10703.42.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Alexandre.Bounine@tundra.com \
--cc=Xin-Xin.Yang@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).