Re: [PATCH][resend] udbg_printf() formatting attribute

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

On Thu, 2006-05-18 at 08:22 -0400, Jimi Xenidis wrote:
> On May 17, 2006, at 7:36 PM, Michael Ellerman wrote:
> 
> > On Wed, 2006-05-17 at 12:00 -0400, jimix@watson.ibm.com wrote:
> >> -	pr_debug("%s: current_entitled = %lu, current_weight = %lu\n",
> >> +	pr_debug("%s: current_entitled = %lu, current_weight = %u\n",
> >>  		 __FUNCTION__, current_entitled, current_weight);
> >>
> >> -	pr_debug("%s: new_entitled = %lu, new_weight = %lu\n",
> >> +	pr_debug("%s: new_entitled = %lu, new_weight = %u\n",
> >>  		 __FUNCTION__, *new_entitled_ptr, *new_weight_ptr);
> >
> > But pr_debug() calls printk, not udbg_printf() ?
> 
> Now _thats_ funny!
> Then I'm so happy to have found and fixed this compiler warning :)

Haha, nice one Jimi :D

> >> -extern void udbg_printf(const char *fmt, ...);
> >> +extern void udbg_printf(const char *fmt, ...)
> >> +	__attribute__ ((format (printf, 1, 2)));
> 
> I believe this chunk is still goodness as it will catch format issues  
> for developers.

I'm actually hoping to get rid of udbg_printf(), but if I can't we
should stick this in I guess. The real problem IMHO is that debug
printks rot because they're rarely compiled, not sure what to do about
that.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]