From: Michael Ellerman <michael@ellerman.id.au>
To: "Mark A. Greer" <mgreer@mvista.com>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs.org>
Subject: Re: [HACK] add sandpoint + flattened dt support to arch/powerpc/boot
Date: Fri, 19 May 2006 10:49:25 +1000 [thread overview]
Message-ID: <1147999765.8515.6.camel@localhost.localdomain> (raw)
In-Reply-To: <20060519003730.GA7338@mag.az.mvista.com>
[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]
On Thu, 2006-05-18 at 17:37 -0700, Mark A. Greer wrote:
> On Thu, May 18, 2006 at 08:47:01AM -0500, Matthew McClintock wrote:
> > On Wed, 2006-05-17 at 17:21 -0700, Mark A. Greer wrote:
> > > +void *
> > > +dt_find_prop_by_name(void *dt_blob, char *full_name, u32 *val_sizep)
> >
> > Is there a reason you are not using of_get_flat_dt_prop() instead of
> > implementing your own version?
>
> Yes. One is in the kernel, one isn't. Or, are you asking why I didn't
> just copy the kernel code? If so, I probably should have.
>
> Hrm, we almost need a library of code shared between the kernel &
> the bootwrapper. Sort of illegal but it would save duplicating code
> like the flat dt code.
>
> Comments?
Yeah we do. And it's not illegal IMHO as two of our boot wrappers
(prom_init and the iSeries one) are linked with the kernel anyway.
I think you should write it ;)
cheers
--
Michael Ellerman
IBM OzLabs
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]
next prev parent reply other threads:[~2006-05-19 0:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 0:21 [HACK] add sandpoint + flattened dt support to arch/powerpc/boot Mark A. Greer
2006-05-18 5:32 ` Benjamin Herrenschmidt
2006-05-18 13:52 ` Matthew McClintock
2006-05-26 6:03 ` Benjamin Herrenschmidt
2006-05-23 0:58 ` Mark A. Greer
2006-05-23 1:13 ` Tom Rini
2006-07-19 20:02 ` Guennadi Liakhovetski
2006-07-19 22:10 ` Mark A. Greer
2006-07-19 22:29 ` Guennadi Liakhovetski
2006-07-20 0:39 ` Mark A. Greer
2006-06-14 3:37 ` Mark A. Greer
2006-05-18 13:47 ` Matthew McClintock
2006-05-19 0:37 ` Mark A. Greer
2006-05-19 0:49 ` Michael Ellerman [this message]
2006-05-22 22:22 ` Tom Rini
2006-06-05 20:41 ` Matthew McClintock
2006-06-05 21:04 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147999765.8515.6.camel@localhost.localdomain \
--to=michael@ellerman.id.au \
--cc=Linuxppc-dev@ozlabs.org \
--cc=mgreer@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).