From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linuxppc-dev@ozlabs.org, johannes@sipsolutions.net,
stern@rowland.harvard.edu, cpufreq@lists.linux.org.uk
Subject: Re: [Fwd: Re: via-pmu runs device_power_down in atomic context]
Date: Thu, 25 May 2006 15:46:24 +1000 [thread overview]
Message-ID: <1148535984.13249.253.camel@localhost.localdomain> (raw)
In-Reply-To: <20060524223658.6fc797f5.akpm@osdl.org>
> This requirement to keep interrupts off in there breaks things again and
> again and again and again. And this time: again.
Where else ?
If you look at this function it's _designed_ for interrupts off ! the
driver suspend have the option of deferring their suspend() callback
until after irqs have been turned off (needed for legacy stuff afaik but
rarely used) and the sysdev's are very low level things whose suspend
and resume callbacks should be called after that point as well.
Ben.
next prev parent reply other threads:[~2006-05-25 5:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1148531830.13249.237.camel@localhost.localdomain>
2006-05-25 4:59 ` [Fwd: Re: via-pmu runs device_power_down in atomic context] Andrew Morton
2006-05-25 5:19 ` Benjamin Herrenschmidt
2006-05-25 5:36 ` Andrew Morton
2006-05-25 5:46 ` Benjamin Herrenschmidt [this message]
2006-05-25 5:53 ` Benjamin Herrenschmidt
2006-05-25 5:44 ` Benjamin Herrenschmidt
2006-05-25 14:12 ` Alan Stern
2006-05-25 14:44 ` Andrew Morton
2006-05-25 16:44 ` Jon Loeliger
2006-05-25 17:53 ` [PATCH] Make cpufreq_transition_notifier a raw notifier Alan Stern
2006-05-25 18:41 ` Johannes Berg
2006-05-25 19:14 ` Alan Stern
2006-05-25 23:18 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148535984.13249.253.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=cpufreq@lists.linux.org.uk \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).