From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Zang Roy-r61911 <tie-fei.zang@freescale.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Yang Xin-Xin-r48390 <Xin-Xin.Yang@freescale.com>,
Paul Mackerras <paulus@samba.org>,
Alexandre.Bounine@tundra.com
Subject: RE: [PATCH/2.6.17-rc4 4/10]Powerpc: Add tsi108 pic support
Date: Tue, 30 May 2006 14:17:48 +1000 [thread overview]
Message-ID: <1148962668.15722.23.camel@localhost.localdomain> (raw)
In-Reply-To: <9FCDBA58F226D911B202000BDBAD467306585F22@zch01exm40.ap.freescale.net>
On Tue, 2006-05-30 at 11:28 +0800, Zang Roy-r61911 wrote:
> Tsi108 implementation of MPIC has many differences form the original one, the following
> code implements it with mpic. Any comment? The following patch is just based on
> my previous send out patches.
>
> Integrate Tundra Semiconductor tsi108 host bridge interrupt controller
> to mpic arch.
As usual... #ifdef's are evil. Only use them to avoid building bits that
are not useful for a given platform, not to change the behaviour of a
driver. By changing the MPIC driver with #ifdef's, you once again
prevent building a generic kernel image that can boot both your board
and pSeries, powermac, etc...
Please add an MPIC flag instead (as there is already for specifying, for
example, big endian MPICs) and add the necessary abstractions (for
example, put some register stride in the mpic instance structure and
initialize them based on the flags etc...)
Cheers,
Ben.
next prev parent reply other threads:[~2006-05-30 4:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-30 3:28 [PATCH/2.6.17-rc4 4/10]Powerpc: Add tsi108 pic support Zang Roy-r61911
2006-05-30 4:17 ` Benjamin Herrenschmidt [this message]
2006-05-30 19:18 ` Kumar Gala
-- strict thread matches above, loose matches on Subject: below --
2006-06-09 9:25 Zang Roy-r61911
2006-06-13 2:09 ` Benjamin Herrenschmidt
2006-06-06 18:58 Alexandre Bounine
2006-06-06 14:45 Alexandre Bounine
2006-06-06 23:08 ` Benjamin Herrenschmidt
2006-06-06 9:43 Zang Roy-r61911
2006-06-06 10:17 ` Benjamin Herrenschmidt
2006-06-02 21:30 Alexandre Bounine
2006-06-01 20:45 Alexandre Bounine
2006-06-01 22:06 ` Benjamin Herrenschmidt
2006-05-17 10:14 Zang Roy-r61911
2006-05-17 16:05 ` Kumar Gala
2006-05-18 0:52 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148962668.15722.23.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Alexandre.Bounine@tundra.com \
--cc=Xin-Xin.Yang@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tie-fei.zang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).