From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: Fix buglet with MMU hash management
Date: Tue, 30 May 2006 14:55:47 +1000 [thread overview]
Message-ID: <1148964948.15722.28.camel@localhost.localdomain> (raw)
In-Reply-To: <20060530043626.GC5101@pb15.lixom.net>
On Mon, 2006-05-29 at 23:36 -0500, Olof Johansson wrote:
> On Tue, May 30, 2006 at 02:14:19PM +1000, Benjamin Herrenschmidt wrote:
>
> > This fixes by allowing the updating of the protection bits in the native
> > hash handling to also set (but not clear) the "C" bit, and, in order to
> > also improve performances in the general case, by always setting that
> > bit on newly inserted hash PTE so that writeback really never happens.
>
> Good catch!
>
> However, you'll have a writeback on the R bit too, you should set that
> together with C.
Nope, R is always set at PTE insertion (it's _PAGE_ACCESSED)
Ben.
prev parent reply other threads:[~2006-05-30 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-30 4:14 [PATCH] powerpc: Fix buglet with MMU hash management Benjamin Herrenschmidt
2006-05-30 4:36 ` Olof Johansson
2006-05-30 4:55 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148964948.15722.28.camel@localhost.localdomain \
--to=benh@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).