Re: pSeries_mach_cpu_die() question

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Fri, 2006-06-02 at 01:19 -0500, Nathan Lynch wrote:

> The cpu parameter is actually unused by in the lpar case:

Ok, missed that :)

> >  - xics has a xics_teardown_cpu() now, used by kexec, that does
> > something very similar except that it passes the proper CPU number, and
> > for secondary CPUs also does an EOI of any pending IPI (just in case). I
> > think that could be used instead of the direct call to the low level
> > pSeriesLP_* funciton (which I itend to unexport and rename anyway as
> > part of my rework). Can whoever knows that code confirm ?
> 
> Sounds okay to me.

Ok. I'll call it with 0 for the "secondary" argument so it doesn't do
the additional EOI of the IPI in order to not change behaviour from the
current code. We can do differently in the future if we want.

> The comment should be changed or removed really.  We got away without
> doing plpar_cppr() on the Power4 hypervisor but we found out it was
> necessary when testing Power5.  I think it's required by the
> architecture regardless, and yes, it's safe on both platforms.

I'll remove the comment.

Thanks !

Cheers,
Ben.