* [PATCH] powerpc: Fix call to ibm,client-architecture-support
@ 2006-06-07 2:01 Benjamin Herrenschmidt
2006-06-07 23:07 ` Segher Boessenkool
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2006-06-07 2:01 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev list
The code in prom_init.c calling the firmware
ibm,client-architecture-support on pSeries has a bug where it fails to
properly pass the instance handle of the firmware object when trying to
call a method. Result ranges from the call doing nothing to the firmware
crashing. (Found by Segher, thanks !)
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Index: linux-work/arch/powerpc/kernel/prom_init.c
===================================================================
--- linux-work.orig/arch/powerpc/kernel/prom_init.c 2006-05-30 13:00:51.000000000 +1000
+++ linux-work/arch/powerpc/kernel/prom_init.c 2006-06-06 11:59:20.000000000 +1000
@@ -822,6 +822,7 @@ static void __init prom_send_capabilitie
/* try calling the ibm,client-architecture-support method */
if (call_prom_ret("call-method", 3, 2, &ret,
ADDR("ibm,client-architecture-support"),
+ root,
ADDR(ibm_architecture_vec)) == 0) {
/* the call exists... */
if (ret)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: Fix call to ibm,client-architecture-support
2006-06-07 2:01 [PATCH] powerpc: Fix call to ibm,client-architecture-support Benjamin Herrenschmidt
@ 2006-06-07 23:07 ` Segher Boessenkool
0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2006-06-07 23:07 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev list, Paul Mackerras
> The code in prom_init.c calling the firmware
> ibm,client-architecture-support on pSeries has a bug where it fails to
> properly pass the instance handle of the firmware object when
> trying to
> call a method. Result ranges from the call doing nothing to the
> firmware
> crashing. (Found by Segher, thanks !)
Dry debugging is one of the most fun things in the world, second
only to reverse engineering. Am I pathetic or what?
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
> Index: linux-work/arch/powerpc/kernel/prom_init.c
> ===================================================================
> --- linux-work.orig/arch/powerpc/kernel/prom_init.c 2006-05-30
> 13:00:51.000000000 +1000
> +++ linux-work/arch/powerpc/kernel/prom_init.c 2006-06-06
> 11:59:20.000000000 +1000
> @@ -822,6 +822,7 @@ static void __init prom_send_capabilitie
> /* try calling the ibm,client-architecture-support method */
> if (call_prom_ret("call-method", 3, 2, &ret,
> ADDR("ibm,client-architecture-support"),
> + root,
> ADDR(ibm_architecture_vec)) == 0) {
> /* the call exists... */
> if (ret)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-07 23:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-07 2:01 [PATCH] powerpc: Fix call to ibm,client-architecture-support Benjamin Herrenschmidt
2006-06-07 23:07 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).