From: Johannes Berg <johannes@sipsolutions.net>
To: alsa-devel@alsa-project.org
Cc: linuxppc-dev@ozlabs.org, netstar@gatheringofgray.com
Subject: Re: [RFC 07/12] snd-aoa: add tas codec
Date: Wed, 07 Jun 2006 17:42:07 +0200 [thread overview]
Message-ID: <1149694927.3925.4.camel@johannes> (raw)
In-Reply-To: <20060607130914.735290000@sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
> + /* older machines have no 'codec' node with a 'compatible'
> + * property that says 'tas3004', they just have a 'deq'
> + * node without any such property... */
> + if (strcmp(dev->name, "deq") == 0) {
> + u32 *addr;
> + printk(KERN_DEBUG PFX "found 'deq' node\n");
> + addr = (u32 *) get_property(dev, "i2c-address", NULL);
> + if (!addr)
> + continue;
> + /* now, if the address doesn't match any of the two
> + * that a tas3004 can have, we cannot handle this.
> + * I doubt it ever happens but hey. */
> + if (*addr != 0x34 && *addr != 0x35)
And I fixed the obvious bug here now.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]
next prev parent reply other threads:[~2006-06-07 15:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 13:09 [RFC 00/12] snd-aoa: add snd-aoa Johannes Berg
2006-06-07 13:09 ` [RFC 01/12] snd-powermac: no longer handle anything with a layout-id property Johannes Berg
2006-06-26 20:49 ` Andreas Schwab
2006-06-27 14:29 ` [Alsa-devel] " Takashi Iwai
2006-06-27 15:32 ` Andreas Schwab
2006-06-29 21:03 ` Andreas Schwab
2006-06-29 22:26 ` Lee Revell
2006-06-29 23:16 ` Andreas Schwab
2006-06-30 9:35 ` Takashi Iwai
2006-07-07 5:38 ` Benjamin Herrenschmidt
2006-07-07 8:04 ` Johannes Berg
2006-07-07 8:13 ` Benjamin Herrenschmidt
2006-07-07 8:22 ` Johannes Berg
2006-07-07 8:27 ` Benjamin Herrenschmidt
2006-07-07 8:40 ` Johannes Berg
2006-07-07 9:51 ` Takashi Iwai
2006-07-07 9:55 ` Johannes Berg
2006-06-27 17:40 ` Johannes Berg
2006-06-27 17:30 ` Johannes Berg
2006-06-07 13:09 ` [RFC 02/12] snd-aoa: add aoa header files Johannes Berg
2006-06-07 13:09 ` [RFC 03/12] snd-aoa: add aoa core Johannes Berg
2006-06-07 18:13 ` [Alsa-devel] " Takashi Iwai
2006-06-09 12:10 ` Johannes Berg
2006-06-07 13:09 ` [RFC 04/12] snd-aoa: add soundbus Johannes Berg
2006-06-07 13:09 ` [RFC 05/12] snd-aoa: add i2sbus Johannes Berg
2006-06-07 18:44 ` [Alsa-devel] " Takashi Iwai
2006-06-09 12:13 ` Johannes Berg
2006-06-09 12:23 ` Takashi Iwai
2006-06-07 13:09 ` [RFC 06/12] snd-aoa: add onyx codec Johannes Berg
2006-06-07 13:09 ` [RFC 07/12] snd-aoa: add tas codec Johannes Berg
2006-06-07 15:42 ` Johannes Berg [this message]
2006-06-07 13:09 ` [RFC 08/12] snd-aoa: add toonie codec Johannes Berg
2006-06-07 13:09 ` [RFC 09/12] snd-aoa: add build files for codecs Johannes Berg
2006-06-07 13:09 ` [RFC 10/12] snd-aoa: add layout-id fabric Johannes Berg
2006-06-07 13:09 ` [RFC 11/12] snd-aoa: add Kconfig and Makefile Johannes Berg
2006-06-07 18:50 ` [Alsa-devel] " Takashi Iwai
2006-06-09 12:10 ` Johannes Berg
2006-06-07 13:09 ` [RFC 12/12] snd-aoa: wire up aoa in sound/ Johannes Berg
2006-06-07 18:22 ` [Alsa-devel] [RFC 00/12] snd-aoa: add snd-aoa Takashi Iwai
2006-06-09 12:22 ` Johannes Berg
2006-06-09 12:34 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149694927.3925.4.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=alsa-devel@alsa-project.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netstar@gatheringofgray.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).