LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 7/10] Add use of mpc86xx.h include files in legacy header files.
Date: Thu, 08 Jun 2006 08:36:56 -0500	[thread overview]
Message-ID: <1149773816.23938.226.camel@cashmere.sps.mot.com> (raw)
In-Reply-To: <542A1CA4-6A5A-41DA-98D2-C61D5376B761@kernel.crashing.org>

On Wed, 2006-06-07 at 23:49, Kumar Gala wrote:
> On Jun 7, 2006, at 5:42 PM, Jon Loeliger wrote:
> 
> >
> > Signed-off-by: Xianghua Xiao <x.xiao@freescale.com>
> > Signed-off-by: Jon Loeliger <jdl@freescale.com>
> >
> > ---
> >
> >  include/asm-ppc/io.h      |    2 ++
> >  include/asm-ppc/ppc_sys.h |    2 ++
> >  include/asm-ppc/serial.h  |    2 ++
> >  3 files changed, 6 insertions(+), 0 deletions(-)
> 
> Are the io.h & serial.h really needed for ARCH=powerpc?  What does  
> serial.h get from asm/mpc86xx.h?  I can see the possibility of io.h  
> needing some stuff from asm/mpc86xx.h

I'll check and do a round of include scrubbing.
There was some silliness going on there earlier,
but it could have been cleaned up along the way too.


> > index 40f197a..4eaf80d 100644
> > --- a/include/asm-ppc/ppc_sys.h
> > +++ b/include/asm-ppc/ppc_sys.h
> > @@ -27,6 +27,8 @@ #elif defined(CONFIG_83xx)
> >  #include <asm/mpc83xx.h>
> >  #elif defined(CONFIG_85xx)
> >  #include <asm/mpc85xx.h>
> > +#elif defined(CONFIG_PPC_86xx)
> > +#include <asm/mpc86xx.h>
> 
> this should go since I can't imagine your using ppc_sys.

Right.  Leftover cleaning tidbits.  It's gone.

Thanks,
jdl

      reply	other threads:[~2006-06-08 13:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-07 22:42 [PATCH 7/10] Add use of mpc86xx.h include files in legacy header files Jon Loeliger
2006-06-08  4:49 ` Kumar Gala
2006-06-08 13:36   ` Jon Loeliger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1149773816.23938.226.camel@cashmere.sps.mot.com \
    --to=jdl@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox