From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jon Loeliger <jdl@freescale.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 4/10 v2] Guard L3CR references with CPU_FTR_L3CR.
Date: Fri, 09 Jun 2006 14:17:59 +1000 [thread overview]
Message-ID: <1149826679.12687.44.camel@localhost.localdomain> (raw)
In-Reply-To: <1149803912.23938.282.camel@cashmere.sps.mot.com>
On Thu, 2006-06-08 at 16:58 -0500, Jon Loeliger wrote:
> Signed-off-by: Jon Loeliger <jdl@freescale.com>
Beware about this one... the CPU setup code might run before the feature
fixup in the future... you should probably do a separate setup function
for your core or go read the feature bit directly in the structure
rather than relying on the fixup mecanism.
> ---
>
> arch/powerpc/kernel/cpu_setup_6xx.S | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>
> diff --git a/arch/powerpc/kernel/cpu_setup_6xx.S b/arch/powerpc/kernel/cpu_setup_6xx.S
> index 55ed771..365381f 100644
> --- a/arch/powerpc/kernel/cpu_setup_6xx.S
> +++ b/arch/powerpc/kernel/cpu_setup_6xx.S
> @@ -210,9 +210,11 @@ setup_745x_specifics:
> * the firmware. If any, we disable NAP capability as
> * it's known to be bogus on rev 2.1 and earlier
> */
> +BEGIN_FTR_SECTION
> mfspr r11,SPRN_L3CR
> andis. r11,r11,L3CR_L3E@h
> beq 1f
> +END_FTR_SECTION_IFSET(CPU_FTR_L3CR)
> lwz r6,CPU_SPEC_FEATURES(r5)
> andi. r0,r6,CPU_FTR_L3_DISABLE_NAP
> beq 1f
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2006-06-09 4:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 21:58 [PATCH 4/10 v2] Guard L3CR references with CPU_FTR_L3CR Jon Loeliger
2006-06-09 4:17 ` Benjamin Herrenschmidt [this message]
2006-06-09 16:00 ` Jon Loeliger
2006-06-09 22:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149826679.12687.44.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=jdl@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).