Re: [Alsa-devel] [RFC 03/12] snd-aoa: add aoa core

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]

On Wed, 2006-06-07 at 20:13 +0200, Takashi Iwai wrote:
> At Wed, 07 Jun 2006 15:09:12 +0200,
> Johannes Berg wrote:
> > 
> > --- /dev/null
> > +++ b/sound/aoa/core/snd-aoa-gpio-pmf.c
> (snip)
> > +void pmf_handle_notify_irq(void *data)
> > +{
> 
> Missing static.

Added, thanks.

> > --- /dev/null
> > +++ b/sound/aoa/core/snd-aoa-gpio-feature.c
> (snip)
> > +static struct device_node *get_gpio(
> > +	char *name, char *altname, int *gpioptr, int *gpioactiveptr)
> 
> Unconventional style.

Heh ok, fixed.

> > +irqreturn_t ftr_handle_notify_irq(int xx, void *data, struct pt_regs *regs)
> > +{
> 
> Missing static.

Added.

> > +static int ftr_set_notify(struct gpio_runtime *rt,
> > +			  enum notify_type type,
> > +			  notify_func_t notify,
> > +			  void *data)
> (snip)
> > +	if (old && !notify) {
> > +		free_irq(irq, notif);
> > +	}
> > +	if (!old && notify) {
> > +		request_irq(irq, ftr_handle_notify_irq, 0, name, notif);
> > +	}
> 
> Remove braces.  

Right.

> Any error check from request_irq()?

Ah, I figured it didn't matter, but it indeed does. Fixed.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]