From: Johannes Berg <johannes@sipsolutions.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org,
netstar@gatheringofgray.com
Subject: Re: [Alsa-devel] [RFC 05/12] snd-aoa: add i2sbus
Date: Fri, 09 Jun 2006 14:13:49 +0200 [thread overview]
Message-ID: <1149855230.3864.19.camel@johannes.berg> (raw)
In-Reply-To: <s5hfyig4xhm.wl%tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
On Wed, 2006-06-07 at 20:44 +0200, Takashi Iwai wrote:
> > + if (I2S_CLOCK_SPEED_18MHz % (rate * mclk) == 0) {
> > + if (!i2s_sf_mclkdiv(I2S_CLOCK_SPEED_18MHz / rate / mclk, out)) {
>
> I'd use "I2S_CLOCK_SPEED_18MHZ / (rate * mclk)"
Yeah, I guess that's clearer then if the multiplication is there twice.
> release_resource() doesn't kfree the record returned from
> request_mem_region().
Hah, ouch. I'll go through and fix them all.
> ALSA has a helper function
> release_and_free_resource() that also does NULL check and kfree:
Why's that helper in alsa of all things? :)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]
next prev parent reply other threads:[~2006-06-09 12:14 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 13:09 [RFC 00/12] snd-aoa: add snd-aoa Johannes Berg
2006-06-07 13:09 ` [RFC 01/12] snd-powermac: no longer handle anything with a layout-id property Johannes Berg
2006-06-26 20:49 ` Andreas Schwab
2006-06-27 14:29 ` [Alsa-devel] " Takashi Iwai
2006-06-27 15:32 ` Andreas Schwab
2006-06-29 21:03 ` Andreas Schwab
2006-06-29 22:26 ` Lee Revell
2006-06-29 23:16 ` Andreas Schwab
2006-06-30 9:35 ` Takashi Iwai
2006-07-07 5:38 ` Benjamin Herrenschmidt
2006-07-07 8:04 ` Johannes Berg
2006-07-07 8:13 ` Benjamin Herrenschmidt
2006-07-07 8:22 ` Johannes Berg
2006-07-07 8:27 ` Benjamin Herrenschmidt
2006-07-07 8:40 ` Johannes Berg
2006-07-07 9:51 ` Takashi Iwai
2006-07-07 9:55 ` Johannes Berg
2006-06-27 17:40 ` Johannes Berg
2006-06-27 17:30 ` Johannes Berg
2006-06-07 13:09 ` [RFC 02/12] snd-aoa: add aoa header files Johannes Berg
2006-06-07 13:09 ` [RFC 03/12] snd-aoa: add aoa core Johannes Berg
2006-06-07 18:13 ` [Alsa-devel] " Takashi Iwai
2006-06-09 12:10 ` Johannes Berg
2006-06-07 13:09 ` [RFC 04/12] snd-aoa: add soundbus Johannes Berg
2006-06-07 13:09 ` [RFC 05/12] snd-aoa: add i2sbus Johannes Berg
2006-06-07 18:44 ` [Alsa-devel] " Takashi Iwai
2006-06-09 12:13 ` Johannes Berg [this message]
2006-06-09 12:23 ` Takashi Iwai
2006-06-07 13:09 ` [RFC 06/12] snd-aoa: add onyx codec Johannes Berg
2006-06-07 13:09 ` [RFC 07/12] snd-aoa: add tas codec Johannes Berg
2006-06-07 15:42 ` Johannes Berg
2006-06-07 13:09 ` [RFC 08/12] snd-aoa: add toonie codec Johannes Berg
2006-06-07 13:09 ` [RFC 09/12] snd-aoa: add build files for codecs Johannes Berg
2006-06-07 13:09 ` [RFC 10/12] snd-aoa: add layout-id fabric Johannes Berg
2006-06-07 13:09 ` [RFC 11/12] snd-aoa: add Kconfig and Makefile Johannes Berg
2006-06-07 18:50 ` [Alsa-devel] " Takashi Iwai
2006-06-09 12:10 ` Johannes Berg
2006-06-07 13:09 ` [RFC 12/12] snd-aoa: wire up aoa in sound/ Johannes Berg
2006-06-07 18:22 ` [Alsa-devel] [RFC 00/12] snd-aoa: add snd-aoa Takashi Iwai
2006-06-09 12:22 ` Johannes Berg
2006-06-09 12:34 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149855230.3864.19.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=alsa-devel@alsa-project.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netstar@gatheringofgray.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).