From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jon Loeliger <jdl@jdl.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 4/10 v2] Guard L3CR references with CPU_FTR_L3CR.
Date: Sat, 10 Jun 2006 08:07:50 +1000 [thread overview]
Message-ID: <1149890870.12687.68.camel@localhost.localdomain> (raw)
In-Reply-To: <E1FojPE-0004Aj-0l@jdl.com>
On Fri, 2006-06-09 at 11:00 -0500, Jon Loeliger wrote:
> So, like, the other day Benjamin Herrenschmidt mumbled:
> > On Thu, 2006-06-08 at 16:58 -0500, Jon Loeliger wrote:
> > > Signed-off-by: Jon Loeliger <jdl@freescale.com>
> >
> > Beware about this one... the CPU setup code might run before the feature
> > fixup in the future...
> > ...
> > or go read the feature bit directly in the structure
> > rather than relying on the fixup mecanism.
>
> OK.
>
> > you should probably do a separate setup function for your core
>
> Truth be told, this is a pretty generic fix for other
> parts as well. If I recall correctly, 7447, 7448, 7448A and 7450
> as well as the new 8641 now.
>
> But I can certainly introduce a new setup function here
> if you think that is the right thing to do. No problem.
No, go for the generic fix.
Ben.
prev parent reply other threads:[~2006-06-09 22:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 21:58 [PATCH 4/10 v2] Guard L3CR references with CPU_FTR_L3CR Jon Loeliger
2006-06-09 4:17 ` Benjamin Herrenschmidt
2006-06-09 16:00 ` Jon Loeliger
2006-06-09 22:07 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149890870.12687.68.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).