From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: pmf_register_irq_client gives sleep with locks held warning
Date: Sun, 11 Jun 2006 08:04:56 +1000 [thread overview]
Message-ID: <1149977097.12687.144.camel@localhost.localdomain> (raw)
In-Reply-To: <1149931638.3864.34.camel@johannes.berg>
On Sat, 2006-06-10 at 11:27 +0200, Johannes Berg wrote:
> On Sat, 2006-06-10 at 10:03 +1000, Benjamin Herrenschmidt wrote:
>
> > > I don't think your patch is right, it seems to me that now
> > > pmf_unregister_irq_client races against pmf_do_irq: what happens when an
> > > interrupt comes in right in the middle of the list_del()?
> >
> > Yeah, possibly... too late for 2.6.17 tho.
>
> That's ok, we don't have any in-kernel users anyway. Alas the alsa
> people will be dissatisfied because they like to ship new drivers for
> old kernels or something. Oh well, I don't care.
We still want people to build out-of-tree for 2.6.17 (please keep the
git there for that), as it will take a while before 2.6.18 is here.
The remaining possible bug in the pmf irq code is probably harmless in
99.99% of the cases in practice :)
Ben.
next prev parent reply other threads:[~2006-06-10 22:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-30 20:19 pmf_register_irq_client gives sleep with locks held warning Johannes Berg
2006-06-01 0:59 ` Benjamin Herrenschmidt
2006-06-08 18:58 ` Johannes Berg
2006-06-10 0:03 ` Benjamin Herrenschmidt
2006-06-10 9:27 ` Johannes Berg
2006-06-10 22:04 ` Benjamin Herrenschmidt [this message]
2006-06-13 8:43 ` Johannes Berg
2006-06-13 9:58 ` Benjamin Herrenschmidt
2006-06-13 15:43 ` [PATCH] make pmf irq_client functions safe against pmf interrupts coming in Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149977097.12687.144.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).