From: Adrian Cox <adrian@humboldt.co.uk>
To: Zang Roy-r61911 <tie-fei.zang@freescale.com>
Cc: Alexandre.Bounine@tundra.com,
Russell King <rmk+lkml@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
linux-serial@vger.kernel.org,
Yang Xin-Xin-r48390 <Xin-Xin.Yang@freescale.com>
Subject: RE: [PATCH/2.6.17-rc4 8/10] Add tsi108 8250 serial support
Date: Wed, 14 Jun 2006 15:25:28 +0100 [thread overview]
Message-ID: <1150295128.6552.35.camel@localhost.localdomain> (raw)
In-Reply-To: <9FCDBA58F226D911B202000BDBAD4673069C3C3D@zch01exm40.ap.freescale.net>
On Tue, 2006-06-13 at 13:39 +0800, Zang Roy-r61911 wrote:
> The reason is that the serial port on tsi108/9 is a bit difference with the
> standard 8250 serial port. the patch deal with the difference.
> The prefixed ">" is caused by "Fw" the email. Sorry for that. The following
> is the original patch.
The problem I see is that the code uses a CONFIG option, to change the
behaviour of the generic 8250 driver. What happens if somebody adds a
PCI serial card to a tsi108 based machine?
Perhaps you should define a new value for uart_8250_port.port.iotype,
and add code to serial_in and serial_out to handle the IIR register.
--
Adrian Cox <adrian@humboldt.co.uk>
next prev parent reply other threads:[~2006-06-14 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-13 5:39 [PATCH/2.6.17-rc4 8/10] Add tsi108 8250 serial support Zang Roy-r61911
2006-06-14 14:25 ` Adrian Cox [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-15 11:04 Zang Roy-r61911
2006-06-15 5:13 Zang Roy-r61911
2006-06-15 3:27 Zang Roy-r61911
2006-05-18 4:00 Zang Roy-r61911
2006-06-05 10:04 ` Russell King
2006-05-17 10:14 Zang Roy-r61911
2006-05-17 13:26 ` Kumar Gala
2006-05-18 1:00 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150295128.6552.35.camel@localhost.localdomain \
--to=adrian@humboldt.co.uk \
--cc=Alexandre.Bounine@tundra.com \
--cc=Xin-Xin.Yang@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tie-fei.zang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).