From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.humboldt.co.uk (mail.humboldt.co.uk [80.68.93.146]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 9034C67B85 for ; Thu, 15 Jun 2006 01:46:51 +1000 (EST) Subject: RE: [PATCH/2.6.17-rc4 8/10] Add tsi108 8250 serial support From: Adrian Cox To: Zang Roy-r61911 In-Reply-To: <9FCDBA58F226D911B202000BDBAD4673069C3C3D@zch01exm40.ap.freescale.net> References: <9FCDBA58F226D911B202000BDBAD4673069C3C3D@zch01exm40.ap.freescale.net> Content-Type: text/plain Date: Wed, 14 Jun 2006 15:25:28 +0100 Message-Id: <1150295128.6552.35.camel@localhost.localdomain> Mime-Version: 1.0 Cc: Alexandre.Bounine@tundra.com, Russell King , linux-kernel@vger.kernel.org, linuxppc-dev list , Paul Mackerras , linux-serial@vger.kernel.org, Yang Xin-Xin-r48390 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2006-06-13 at 13:39 +0800, Zang Roy-r61911 wrote: > The reason is that the serial port on tsi108/9 is a bit difference with the > standard 8250 serial port. the patch deal with the difference. > The prefixed ">" is caused by "Fw" the email. Sorry for that. The following > is the original patch. The problem I see is that the code uses a CONFIG option, to change the behaviour of the generic 8250 driver. What happens if somebody adds a PCI serial card to a tsi108 based machine? Perhaps you should define a new value for uart_8250_port.port.iotype, and add code to serial_in and serial_out to handle the IIR register. -- Adrian Cox