From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Olof Johansson <olof@lixom.net>,
linuxppc-dev <Linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] mpic: add support for serial mode interrupts
Date: Wed, 21 Jun 2006 11:12:36 +1000 [thread overview]
Message-ID: <1150852356.12507.32.camel@localhost.localdomain> (raw)
In-Reply-To: <92B1CE9B-81D2-4943-9B6A-68459407688A@kernel.crashing.org>
On Tue, 2006-06-20 at 00:35 +0200, Segher Boessenkool wrote:
> > Can you define some constants so others can see just what the bits
> > mean
> > without digging up documentation, instead of just doing magic numbers?
>
> [my favourite argument :-) ]
>
> You'll have to read the documentation to properly understand what
> the bit patterns mean anyway. And if you use symbolic names, you
> only add another step: hunting through header files.
Sure, that's why we should remove every symbolic constant in every
driver anywhere in the kernel right ? Sure would help.
Ben.
next prev parent reply other threads:[~2006-06-21 1:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-19 20:08 [PATCH] mpic: add support for serial mode interrupts Mark A. Greer
2006-06-19 20:11 ` Olof Johansson
2006-06-19 20:19 ` Mark A. Greer
2006-06-19 22:35 ` Segher Boessenkool
2006-06-21 1:12 ` Benjamin Herrenschmidt [this message]
2006-06-19 22:03 ` Mark A. Greer
2006-06-20 4:01 ` Benjamin Herrenschmidt
2006-06-20 16:37 ` Mark A. Greer
2006-06-20 21:15 ` Mark A. Greer
2006-06-20 22:04 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150852356.12507.32.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox