From: Michael Ellerman <michael@ellerman.id.au>
To: Kelly Daly <kelly@au1.ibm.com>
Cc: linuxppc64-dev@ozlabs.org, paulus@samba.org, anton@samba.org
Subject: Re: [PATCH] powerpc: disable OProfile for iSeries (take 2!)
Date: Wed, 21 Jun 2006 13:10:33 +1000 [thread overview]
Message-ID: <1150859433.8293.9.camel@localhost.localdomain> (raw)
In-Reply-To: <200606211151.01386.kelly@au.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]
On Wed, 2006-06-21 at 11:51 +1000, Kelly Daly wrote:
> This patch removes the changes from an earlier patch that disables oProfile for iSeries within the oProfile KConfig (submitted Feb 23, 2006). Checks within the arch init for iSeries, still allowing profiling for timer interrupts.
>
> Signed-off-by: Kelly Daly <kelly@au.ibm.com>
> ---
>
>
> diff -urdp linux-2.6.16.20/arch/powerpc/oprofile/Kconfig linux-2.6.16.20_kel/arch/powerpc/oprofile/Kconfig
> --- linux-2.6.16.20/arch/powerpc/oprofile/Kconfig 2006-06-06 03:18:23.000000000 +1000
> +++ linux-2.6.16.20_kel/arch/powerpc/oprofile/Kconfig 2006-06-20 15:53:02.000000000 +1000
> @@ -1,5 +1,4 @@
> config PROFILING
> - depends on !PPC_ISERIES
> bool "Profiling support (EXPERIMENTAL)"
> help
> Say Y here to enable the extended profiling support mechanisms used
> diff -urdp linux-2.6.16.20/arch/powerpc/oprofile/common.c linux-2.6.16.20_kel/arch/powerpc/oprofile/common.c
> --- linux-2.6.16.20/arch/powerpc/oprofile/common.c 2006-06-06 03:18:23.000000000 +1000
> +++ linux-2.6.16.20_kel/arch/powerpc/oprofile/common.c 2006-06-20 15:33:56.000000000 +1000
> @@ -137,7 +137,10 @@ int __init oprofile_arch_init(struct opr
> {
> if (!cur_cpu_spec->oprofile_cpu_type)
> return -ENODEV;
> -
> +#ifdef CONFIG_PPC_ISERIES
> + return -ENODEV;
> +#endif
> +
AFAICT that still doesn't let us build a combined kernel, but I haven't
looked at the code.
cheers
--
Michael Ellerman
IBM OzLabs
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]
next prev parent reply other threads:[~2006-06-21 3:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 1:51 [PATCH] powerpc: disable OProfile for iSeries (take 2!) Kelly Daly
2006-06-21 3:10 ` Michael Ellerman [this message]
2006-06-21 3:52 ` Kelly Daly
2006-06-21 4:32 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150859433.8293.9.camel@localhost.localdomain \
--to=michael@ellerman.id.au \
--cc=anton@samba.org \
--cc=kelly@au1.ibm.com \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).