* [PATCH 4/20] Mark platform device data as const
@ 2006-07-04 6:47 Jeremy Kerr
0 siblings, 0 replies; 2+ messages in thread
From: Jeremy Kerr @ 2006-07-04 6:47 UTC (permalink / raw)
To: linuxppc-dev; +Cc: greg
platform_device_add_data()'s data argument can be qualified as const -
the function just copies it to another buffer.
This neatens-up storing other const-ed data there.
Built for powerpc and i386
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
---
paulus - pending Greg KH's ack, please apply
platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6/drivers/base/platform.c
===================================================================
--- linux-2.6.orig/drivers/base/platform.c
+++ linux-2.6/drivers/base/platform.c
@@ -212,7 +212,8 @@ EXPORT_SYMBOL_GPL(platform_device_add_re
* pointer. The memory associated with the platform data will be freed
* when the platform device is released.
*/
-int platform_device_add_data(struct platform_device *pdev, void *data, size_t size)
+int platform_device_add_data(struct platform_device *pdev, const void *data,
+ size_t size)
{
void *d;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 4/20] Mark platform device data as const
[not found] <45499930@toto.iv>
@ 2006-07-06 23:41 ` Paul Mackerras
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mackerras @ 2006-07-06 23:41 UTC (permalink / raw)
To: Jeremy Kerr; +Cc: linuxppc-dev, greg
Jeremy Kerr writes:
> platform_device_add_data()'s data argument can be qualified as const -
> the function just copies it to another buffer.
Ummm, you change the actual function definition here, but you put the
change to the declaration in include/linux/platform_device.h in your
[5/20] patch. Please redo this patch with the change to the
declaration included.
Paul.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-06 23:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-04 6:47 [PATCH 4/20] Mark platform device data as const Jeremy Kerr
[not found] <45499930@toto.iv>
2006-07-06 23:41 ` Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).