From: Johannes Berg <johannes@sipsolutions.net>
To: Aristeu Sergio Rozanski Filho <aris@valeta.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powermac: defer work in backlight key press
Date: Tue, 04 Jul 2006 10:06:59 +0200 [thread overview]
Message-ID: <1152000419.20701.48.camel@localhost> (raw)
In-Reply-To: <20060704013923.GG27596@cathedrallabs.org>
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
>
> + /* we can receive multiple interrupts here, but the scheduled work
> + * will run only once, with the last value */
> + pmac_backlight_key_queued = direction;
Shouldn't you be doing something like using the whole
pmac_backlight_key_queued in the workqueue, then setting it to 0 there
and using += here? That way all keypresses will be adhered to.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2006-07-04 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-04 1:39 [PATCH] powermac: defer work in backlight key press Aristeu Sergio Rozanski Filho
2006-07-04 8:06 ` Johannes Berg [this message]
2006-07-04 11:03 ` Aristeu Sergio Rozanski Filho
2006-07-04 11:16 ` Johannes Berg
2006-07-08 14:35 ` Michael Hanselmann
2006-07-08 15:58 ` [PATCH] powermac: defer work in backlight key press (and export fixes) Michael Hanselmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152000419.20701.48.camel@localhost \
--to=johannes@sipsolutions.net \
--cc=aris@valeta.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).