From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>, alsa-devel@alsa-project.org
Subject: Re: snd-aoa: g5 tas codec problems
Date: Fri, 07 Jul 2006 11:04:33 +0200 [thread overview]
Message-ID: <1152263073.15068.32.camel@localhost> (raw)
In-Reply-To: <1152262585.9862.61.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Fri, 2006-07-07 at 18:56 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2006-07-07 at 10:49 +0200, Johannes Berg wrote:
> > On Fri, 2006-07-07 at 17:47 +1000, Benjamin Herrenschmidt wrote:
> > > Also, we should try
> > > (if not already the case) to cache our clock/i2s state so that
> > > subsequent prepare() don't try to change things that are already ok.
> >
> > I do that, the function reads the dws and sfr registers and exits early
> > if they match.
>
> Ok. Be careful that I've removed the initial init of TAS thinking we
> always get to clock restart to do it in prepare()... might need to be
> put back.
Oh yes, we do, wonder why it even worked then since most of the time
we'll be using whatever the firmware does (44.1KHz,16bit).
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2006-07-07 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 7:47 snd-aoa: g5 tas codec problems Benjamin Herrenschmidt
2006-07-07 7:50 ` Benjamin Herrenschmidt
2006-07-07 13:43 ` Johannes Berg
2006-07-07 8:03 ` Johannes Berg
2006-07-07 8:12 ` Benjamin Herrenschmidt
2006-07-07 8:49 ` Johannes Berg
2006-07-07 8:56 ` Benjamin Herrenschmidt
2006-07-07 9:04 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152263073.15068.32.camel@localhost \
--to=johannes@sipsolutions.net \
--cc=alsa-devel@alsa-project.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).