From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Amos Waterland <apw@us.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: mpic discovery on JS20
Date: Fri, 21 Jul 2006 13:37:56 -0400 [thread overview]
Message-ID: <1153503476.16159.13.camel@localhost.localdomain> (raw)
In-Reply-To: <20060720231601.GA24736@kvasir.watson.ibm.com>
On Thu, 2006-07-20 at 19:16 -0400, Amos Waterland wrote:
> Current Linus and Paulus trees do this on JS20 blades with SLOF:
I need a tarball of /proc/device-tree on these.
> Failed to locate the MPIC interrupt controller
> PID hash table entries: 4096 (order: 12, 32768 bytes)
> Maple: Found RTC at IO 0x1070
> cpu 0x0: Vector: 700 (Program Check) at [c00000007ef83ab0]
> pc: c00000000002e0c8: .mpic_request_ipis+0x34/0xc8
> lr: c00000000036b484: .smp_mpic_probe+0x3c/0x58
> sp: c00000007ef83d30
> msr: 9000000000029032
> current = 0xc00000000194d610
> paca = 0xc00000000038f180
> pid = 1, comm = swapper
> kernel BUG in mpic_request_ipis at arch/powerpc/sysdev/mpic.c:1132!
>
> Doing a git-bisect produces this:
>
> 0ebfff1491ef85d41ddf9c633834838be144f69f is first bad commit
> Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Date: Mon Jul 3 21:36:01 2006 +1000
>
> [POWERPC] Add new interrupt mapping core and change platforms to use it
>
> This adds the new irq remapper core and removes the old one. Because
> there are some fundamental conflicts with the old code, like the value
> of NO_IRQ which I'm now setting to 0 (as per discussions with Linus),
> etc..., this commit also changes the relevant platform and driver code
> over to use the new remapper (so as not to cause difficulties later
> in bisecting).
>
> This patch removes the old pre-parsing of the open firmware interrupt
> tree along with all the bogus assumptions it made to try to renumber
> interrupts according to the platform. This is all to be handled by the
> new code now.
>
> For the pSeries XICS interrupt controller, a single remapper host is
> created for the whole machine regardless of how many interrupt
> presentation and source controllers are found, and it's set to match
> any device node that isn't a 8259. That works fine on pSeries and
> avoids having to deal with some of the complexities of split source
> controllers vs. presentation controllers in the pSeries device trees.
>
> The powerpc i8259 PIC driver now always requests the legacy interrupt
> range. It also has the feature of being able to match any device node
> (including NULL) if passed no device node as an input. That will help
> porting over platforms with broken device-trees like Pegasos who don't
> have a proper interrupt tree.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2006-07-21 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 23:16 mpic discovery on JS20 Amos Waterland
2006-07-21 17:37 ` Benjamin Herrenschmidt [this message]
2006-07-24 21:09 ` Amos Waterland
2006-07-24 7:41 ` Michael Ellerman
2006-07-24 18:20 ` Segher Boessenkool
2006-07-25 1:54 ` Michael Ellerman
2006-07-25 3:41 ` Segher Boessenkool
2006-07-24 21:07 ` Amos Waterland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153503476.16159.13.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=apw@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).