From: Hollis Blanchard <hollis@alumni.cmu.edu>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: akpm@osdl.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pSeries hvsi char driver null pointer deref
Date: Sun, 06 Aug 2006 18:49:22 -0500 [thread overview]
Message-ID: <1154908162.27074.2.camel@diesel> (raw)
In-Reply-To: <20060803201300.GB10638@austin.ibm.com>
On Thu, 2006-08-03 at 15:13 -0500, Linas Vepstas wrote:
> Andrew,
> Please apply.
>
> Under certain rare circumstances, it appears that there can be
> be a NULL-pointer deref when a user fiddles with terminal
> emeulation programs while outpu is being sent to the console.
> This patch checks for and avoids a NULL-pointer deref.
>
> Signed-off-by: Hollis Blanchard <hollisbl@austin.ibm.com>
> Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
That email address is incorrect.
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> ----
> drivers/char/hvsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-2.6.18-rc3-git1/drivers/char/hvsi.c
> ===================================================================
> --- linux-2.6.18-rc3-git1.orig/drivers/char/hvsi.c 2006-08-03 14:50:00.000000000 -0500
> +++ linux-2.6.18-rc3-git1/drivers/char/hvsi.c 2006-08-03 14:51:46.000000000 -0500
> @@ -311,7 +311,8 @@ static void hvsi_recv_control(struct hvs
> /* CD went away; no more connection */
> pr_debug("hvsi%i: CD dropped\n", hp->index);
> hp->mctrl &= TIOCM_CD;
> - if (!(hp->tty->flags & CLOCAL))
> + /* If userland hasn't done an open(2) yet, hp->tty is NULL. */
> + if (hp->tty && !(hp->tty->flags & CLOCAL))
> *to_hangup = hp->tty;
> }
> break;
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
prev parent reply other threads:[~2006-08-06 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-03 20:13 [PATCH] pSeries hvsi char driver null pointer deref Linas Vepstas
2006-08-06 23:49 ` Hollis Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154908162.27074.2.camel@diesel \
--to=hollis@alumni.cmu.edu \
--cc=akpm@osdl.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox