From: Michael Ellerman <michael@ellerman.id.au>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, anton@samba.org
Subject: Re: [PATCH] powerpc: Make RTAS console init generic
Date: Thu, 17 Aug 2006 10:44:12 +1000 [thread overview]
Message-ID: <1155775453.6910.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20060816152303.7AF4967B5A@ozlabs.org>
[-- Attachment #1: Type: text/plain, Size: 2991 bytes --]
On Wed, 2006-08-16 at 10:22 -0500, Michael Neuling wrote:
> In message <1155705695.12715.7.camel@localhost.localdomain> you wrote:
> >
> > --=-PNKyW5KJv4630LcmkXVt
> > Content-Type: text/plain
> > Content-Transfer-Encoding: quoted-printable
> >
> > On Tue, 2006-08-15 at 23:00 -0500, Michael Neuling wrote:
> > > The RTAS console doesn't have to be Cell specific. If we have both
> > > the put and get char RTAS functions, init the rtas console.
> > >=20
> > > Index: linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > --- linux-2.6-ozlabs.orig/arch/powerpc/kernel/rtas.c
> > > +++ linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
> > > @@ -910,6 +910,11 @@ int __init early_init_dt_scan_rtas(unsig
> > > basep =3D of_get_flat_dt_prop(node, "get-term-char", NULL);
> > > if (basep)
> > > rtas_getchar_token =3D *basep;
> > > +
> > > + if (rtas_putchar_token !=3D RTAS_UNKNOWN_SERVICE &&
> > > + rtas_getchar_token !=3D RTAS_UNKNOWN_SERVICE)
> > > + udbg_init_rtas_console();
> > > +
> > > #endif
> > > =20
> > > /* break now */
> > > Index: linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > --- linux-2.6-ozlabs.orig/arch/powerpc/platforms/cell/setup.c
> > > +++ linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
> > > @@ -150,10 +150,6 @@ static int __init cell_probe(void)
> > > !of_flat_dt_is_compatible(root, "IBM,CPBW-1.0"))
> > > return 0;
> > > =20
> > > -#ifdef CONFIG_UDBG_RTAS_CONSOLE
> > > - udbg_init_rtas_console();
> > > -#endif
> > > -
> >
> > I'd like to see it still guarded by UDBG_RTAS_CONSOLE, otherwise there's
> > no way to select a different type of early console on a machine which
> > has those tokens in the device tree.
>
> Agreed but that section in rtas.c is already guarded by
> UDBG_RTAS_CONSOLE. After applying the patch, it looks like:
>
> #ifdef CONFIG_UDBG_RTAS_CONSOLE
> basep = of_get_flat_dt_prop(node, "put-term-char", NULL);
> if (basep)
> rtas_putchar_token = *basep;
>
> basep = of_get_flat_dt_prop(node, "get-term-char", NULL);
> if (basep)
> rtas_getchar_token = *basep;
>
> if (rtas_putchar_token != RTAS_UNKNOWN_SERVICE &&
> rtas_getchar_token != RTAS_UNKNOWN_SERVICE)
> udbg_init_rtas_console();
>
> #endif
Ah sorry, I just looked at the patch.
cheers
--
Michael Ellerman
IBM OzLabs
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]
next prev parent reply other threads:[~2006-08-17 0:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-16 4:00 [PATCH] powerpc: Make RTAS console init generic Michael Neuling
2006-08-16 5:21 ` Michael Ellerman
2006-08-16 15:22 ` Michael Neuling
2006-08-17 0:44 ` Michael Ellerman [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-16 19:42 Michael Neuling
2006-08-17 2:04 ` Michael Ellerman
2006-08-17 3:27 ` Michael Neuling
2006-08-17 3:45 ` Michael Ellerman
2006-08-17 4:02 ` Michael Neuling
2006-08-17 4:12 Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155775453.6910.2.camel@localhost.localdomain \
--to=michael@ellerman.id.au \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).