From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id DB6A867B75 for ; Thu, 17 Aug 2006 12:01:52 +1000 (EST) Subject: [PATCH] Fix irq radix tree remapping typo From: Benjamin Herrenschmidt To: Paul Mackerras Content-Type: text/plain Date: Thu, 17 Aug 2006 03:59:27 +0200 Message-Id: <1155779967.11312.143.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev list , Manoj Iyer List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , The code for using the radix tree for reverse mapping of interrupts has a typo that causes it to create incorrect mappings if the software and hardware numbers happen to be different. This would, among others, cause the IDE interrupt to fail on js20's. This fixes it. Signed-off-by: Benjamin Herrenschmidt --- Please apply to 2.6.18 Index: linux-work/arch/powerpc/kernel/irq.c =================================================================== --- linux-work.orig/arch/powerpc/kernel/irq.c 2006-08-17 09:26:19.000000000 +1000 +++ linux-work/arch/powerpc/kernel/irq.c 2006-08-17 11:27:30.000000000 +1000 @@ -693,7 +693,7 @@ unsigned int irq_radix_revmap(struct irq /* If not there, try to insert it */ virq = irq_find_mapping(host, hwirq); if (virq != NO_IRQ) - radix_tree_insert(tree, virq, &irq_map[virq]); + radix_tree_insert(tree, hwirq, &irq_map[virq]); bail: spin_unlock_irqrestore(&irq_big_lock, flags); return virq;