linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: Make RTAS console init generic
@ 2006-08-16  4:00 Michael Neuling
  2006-08-16  5:21 ` Michael Ellerman
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Neuling @ 2006-08-16  4:00 UTC (permalink / raw)
  To: paulus; +Cc: linuxppc-dev, anton

The RTAS console doesn't have to be Cell specific.  If we have both
the put and get char RTAS functions, init the rtas console.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
Paulus: This is relatively low risk, so if the Cell guys ack it, it
could be a candidate for 2.6.18.

 arch/powerpc/kernel/rtas.c          |    5 +++++
 arch/powerpc/platforms/cell/setup.c |    4 ----
 2 files changed, 5 insertions(+), 4 deletions(-)

Index: linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/kernel/rtas.c
+++ linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
@@ -910,6 +910,11 @@ int __init early_init_dt_scan_rtas(unsig
 	basep = of_get_flat_dt_prop(node, "get-term-char", NULL);
 	if (basep)
 		rtas_getchar_token = *basep;
+
+	if (rtas_putchar_token != RTAS_UNKNOWN_SERVICE &&
+	    rtas_getchar_token != RTAS_UNKNOWN_SERVICE)
+		udbg_init_rtas_console();
+
 #endif
 
 	/* break now */
Index: linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/platforms/cell/setup.c
+++ linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
@@ -150,10 +150,6 @@ static int __init cell_probe(void)
 	    !of_flat_dt_is_compatible(root, "IBM,CPBW-1.0"))
 		return 0;
 
-#ifdef CONFIG_UDBG_RTAS_CONSOLE
-	udbg_init_rtas_console();
-#endif
-
 	hpte_init_native();
 
 	return 1;

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] powerpc: Make RTAS console init generic
  2006-08-16  4:00 Michael Neuling
@ 2006-08-16  5:21 ` Michael Ellerman
  2006-08-16 15:22   ` Michael Neuling
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Ellerman @ 2006-08-16  5:21 UTC (permalink / raw)
  To: Michael Neuling; +Cc: linuxppc-dev, paulus, anton

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

On Tue, 2006-08-15 at 23:00 -0500, Michael Neuling wrote:
> The RTAS console doesn't have to be Cell specific.  If we have both
> the put and get char RTAS functions, init the rtas console.
> 
> Index: linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
> ===================================================================
> --- linux-2.6-ozlabs.orig/arch/powerpc/kernel/rtas.c
> +++ linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
> @@ -910,6 +910,11 @@ int __init early_init_dt_scan_rtas(unsig
>  	basep = of_get_flat_dt_prop(node, "get-term-char", NULL);
>  	if (basep)
>  		rtas_getchar_token = *basep;
> +
> +	if (rtas_putchar_token != RTAS_UNKNOWN_SERVICE &&
> +	    rtas_getchar_token != RTAS_UNKNOWN_SERVICE)
> +		udbg_init_rtas_console();
> +
>  #endif
>  
>  	/* break now */
> Index: linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
> ===================================================================
> --- linux-2.6-ozlabs.orig/arch/powerpc/platforms/cell/setup.c
> +++ linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
> @@ -150,10 +150,6 @@ static int __init cell_probe(void)
>  	    !of_flat_dt_is_compatible(root, "IBM,CPBW-1.0"))
>  		return 0;
>  
> -#ifdef CONFIG_UDBG_RTAS_CONSOLE
> -	udbg_init_rtas_console();
> -#endif
> -

I'd like to see it still guarded by UDBG_RTAS_CONSOLE, otherwise there's
no way to select a different type of early console on a machine which
has those tokens in the device tree.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] powerpc: Make RTAS console init generic
  2006-08-16  5:21 ` Michael Ellerman
@ 2006-08-16 15:22   ` Michael Neuling
  2006-08-17  0:44     ` Michael Ellerman
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Neuling @ 2006-08-16 15:22 UTC (permalink / raw)
  To: michael; +Cc: linuxppc-dev, paulus, anton

In message <1155705695.12715.7.camel@localhost.localdomain> you wrote:
> 
> --=-PNKyW5KJv4630LcmkXVt
> Content-Type: text/plain
> Content-Transfer-Encoding: quoted-printable
> 
> On Tue, 2006-08-15 at 23:00 -0500, Michael Neuling wrote:
> > The RTAS console doesn't have to be Cell specific.  If we have both
> > the put and get char RTAS functions, init the rtas console.
> >=20
> > Index: linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- linux-2.6-ozlabs.orig/arch/powerpc/kernel/rtas.c
> > +++ linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
> > @@ -910,6 +910,11 @@ int __init early_init_dt_scan_rtas(unsig
> >  	basep =3D of_get_flat_dt_prop(node, "get-term-char", NULL);
> >  	if (basep)
> >  		rtas_getchar_token =3D *basep;
> > +
> > +	if (rtas_putchar_token !=3D RTAS_UNKNOWN_SERVICE &&
> > +	    rtas_getchar_token !=3D RTAS_UNKNOWN_SERVICE)
> > +		udbg_init_rtas_console();
> > +
> >  #endif
> > =20
> >  	/* break now */
> > Index: linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- linux-2.6-ozlabs.orig/arch/powerpc/platforms/cell/setup.c
> > +++ linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
> > @@ -150,10 +150,6 @@ static int __init cell_probe(void)
> >  	    !of_flat_dt_is_compatible(root, "IBM,CPBW-1.0"))
> >  		return 0;
> > =20
> > -#ifdef CONFIG_UDBG_RTAS_CONSOLE
> > -	udbg_init_rtas_console();
> > -#endif
> > -
> 
> I'd like to see it still guarded by UDBG_RTAS_CONSOLE, otherwise there's
> no way to select a different type of early console on a machine which
> has those tokens in the device tree.

Agreed but that section in rtas.c is already guarded by
UDBG_RTAS_CONSOLE.  After applying the patch, it looks like: 

#ifdef CONFIG_UDBG_RTAS_CONSOLE
	basep = of_get_flat_dt_prop(node, "put-term-char", NULL);
	if (basep)
		rtas_putchar_token = *basep;

	basep = of_get_flat_dt_prop(node, "get-term-char", NULL);
	if (basep)
		rtas_getchar_token = *basep;

	if (rtas_putchar_token != RTAS_UNKNOWN_SERVICE &&
	    rtas_getchar_token != RTAS_UNKNOWN_SERVICE)
		udbg_init_rtas_console();

#endif

Mikey

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] powerpc: Make RTAS console init generic
@ 2006-08-16 19:42 Michael Neuling
  2006-08-17  2:04 ` Michael Ellerman
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Neuling @ 2006-08-16 19:42 UTC (permalink / raw)
  To: paulus; +Cc: linuxppc-dev, anton

The rtas console doesn't have to be Cell specific.  If we get both
rtas tokens, we should just enabled the console then and there.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
Updated Kconfig so we can enable it.  

 arch/powerpc/Kconfig                |    2 +-
 arch/powerpc/kernel/rtas.c          |    5 +++++
 arch/powerpc/platforms/cell/setup.c |    4 ----
 3 files changed, 6 insertions(+), 5 deletions(-)

Index: linux-2.6-ozlabs/arch/powerpc/Kconfig
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/Kconfig
+++ linux-2.6-ozlabs/arch/powerpc/Kconfig
@@ -426,7 +426,7 @@ config PPC_IBM_CELL_BLADE
 	select UDBG_RTAS_CONSOLE
 
 config UDBG_RTAS_CONSOLE
-	bool
+	bool "RTAS based debug console"
 	default n
 
 config XICS
Index: linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/kernel/rtas.c
+++ linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
@@ -910,6 +910,11 @@ int __init early_init_dt_scan_rtas(unsig
 	basep = of_get_flat_dt_prop(node, "get-term-char", NULL);
 	if (basep)
 		rtas_getchar_token = *basep;
+
+	if (rtas_putchar_token != RTAS_UNKNOWN_SERVICE &&
+	    rtas_getchar_token != RTAS_UNKNOWN_SERVICE)
+		udbg_init_rtas_console();
+
 #endif
 
 	/* break now */
Index: linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/platforms/cell/setup.c
+++ linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
@@ -150,10 +150,6 @@ static int __init cell_probe(void)
 	    !of_flat_dt_is_compatible(root, "IBM,CPBW-1.0"))
 		return 0;
 
-#ifdef CONFIG_UDBG_RTAS_CONSOLE
-	udbg_init_rtas_console();
-#endif
-
 	hpte_init_native();
 
 	return 1;

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] powerpc: Make RTAS console init generic
  2006-08-16 15:22   ` Michael Neuling
@ 2006-08-17  0:44     ` Michael Ellerman
  0 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2006-08-17  0:44 UTC (permalink / raw)
  To: Michael Neuling; +Cc: linuxppc-dev, paulus, anton

[-- Attachment #1: Type: text/plain, Size: 2991 bytes --]

On Wed, 2006-08-16 at 10:22 -0500, Michael Neuling wrote:
> In message <1155705695.12715.7.camel@localhost.localdomain> you wrote:
> > 
> > --=-PNKyW5KJv4630LcmkXVt
> > Content-Type: text/plain
> > Content-Transfer-Encoding: quoted-printable
> > 
> > On Tue, 2006-08-15 at 23:00 -0500, Michael Neuling wrote:
> > > The RTAS console doesn't have to be Cell specific.  If we have both
> > > the put and get char RTAS functions, init the rtas console.
> > >=20
> > > Index: linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > --- linux-2.6-ozlabs.orig/arch/powerpc/kernel/rtas.c
> > > +++ linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
> > > @@ -910,6 +910,11 @@ int __init early_init_dt_scan_rtas(unsig
> > >  	basep =3D of_get_flat_dt_prop(node, "get-term-char", NULL);
> > >  	if (basep)
> > >  		rtas_getchar_token =3D *basep;
> > > +
> > > +	if (rtas_putchar_token !=3D RTAS_UNKNOWN_SERVICE &&
> > > +	    rtas_getchar_token !=3D RTAS_UNKNOWN_SERVICE)
> > > +		udbg_init_rtas_console();
> > > +
> > >  #endif
> > > =20
> > >  	/* break now */
> > > Index: linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > --- linux-2.6-ozlabs.orig/arch/powerpc/platforms/cell/setup.c
> > > +++ linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
> > > @@ -150,10 +150,6 @@ static int __init cell_probe(void)
> > >  	    !of_flat_dt_is_compatible(root, "IBM,CPBW-1.0"))
> > >  		return 0;
> > > =20
> > > -#ifdef CONFIG_UDBG_RTAS_CONSOLE
> > > -	udbg_init_rtas_console();
> > > -#endif
> > > -
> > 
> > I'd like to see it still guarded by UDBG_RTAS_CONSOLE, otherwise there's
> > no way to select a different type of early console on a machine which
> > has those tokens in the device tree.
> 
> Agreed but that section in rtas.c is already guarded by
> UDBG_RTAS_CONSOLE.  After applying the patch, it looks like: 
> 
> #ifdef CONFIG_UDBG_RTAS_CONSOLE
> 	basep = of_get_flat_dt_prop(node, "put-term-char", NULL);
> 	if (basep)
> 		rtas_putchar_token = *basep;
> 
> 	basep = of_get_flat_dt_prop(node, "get-term-char", NULL);
> 	if (basep)
> 		rtas_getchar_token = *basep;
> 
> 	if (rtas_putchar_token != RTAS_UNKNOWN_SERVICE &&
> 	    rtas_getchar_token != RTAS_UNKNOWN_SERVICE)
> 		udbg_init_rtas_console();
> 
> #endif

Ah sorry, I just looked at the patch.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] powerpc: Make RTAS console init generic
  2006-08-16 19:42 [PATCH] powerpc: Make RTAS console init generic Michael Neuling
@ 2006-08-17  2:04 ` Michael Ellerman
  2006-08-17  3:27   ` Michael Neuling
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Ellerman @ 2006-08-17  2:04 UTC (permalink / raw)
  To: Michael Neuling; +Cc: linuxppc-dev, paulus, anton

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Wed, 2006-08-16 at 14:42 -0500, Michael Neuling wrote:
> The rtas console doesn't have to be Cell specific.  If we get both
> rtas tokens, we should just enabled the console then and there.
> 

Seems to work fine on Cell.

> Updated Kconfig so we can enable it.  

I enable it via the early debugging menu (under kernel hacking), is that
not good enough?

>  arch/powerpc/Kconfig                |    2 +-
>  arch/powerpc/kernel/rtas.c          |    5 +++++
>  arch/powerpc/platforms/cell/setup.c |    4 ----
>  3 files changed, 6 insertions(+), 5 deletions(-)
> 
> Index: linux-2.6-ozlabs/arch/powerpc/Kconfig
> ===================================================================
> --- linux-2.6-ozlabs.orig/arch/powerpc/Kconfig
> +++ linux-2.6-ozlabs/arch/powerpc/Kconfig
> @@ -426,7 +426,7 @@ config PPC_IBM_CELL_BLADE
>  	select UDBG_RTAS_CONSOLE
>  
>  config UDBG_RTAS_CONSOLE
> -	bool
> +	bool "RTAS based debug console"
>  	default n

This should probably depend on RTAS?

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] powerpc: Make RTAS console init generic
  2006-08-17  2:04 ` Michael Ellerman
@ 2006-08-17  3:27   ` Michael Neuling
  2006-08-17  3:45     ` Michael Ellerman
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Neuling @ 2006-08-17  3:27 UTC (permalink / raw)
  To: michael; +Cc: linuxppc-dev, paulus, anton

> Seems to work fine on Cell.

Kewl

> > Updated Kconfig so we can enable it. 
> 
> I enable it via the early debugging menu (under kernel hacking), is that
> not good enough?

Doesn't that enable CONFIG_PPC_EARLY_DEBUG_RTAS_CONSOLE not
CONFIG_UDBG_RTAS_CONSOLE?

Without the Kconfig update you don't seem to get presented with an
option but I'm no kbuild expert.

> >  config UDBG_RTAS_CONSOLE
> > -	bool
> > +	bool "RTAS based debug console"
> >  	default n
> 
> This should probably depend on RTAS?

Yeap.

Mikey

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] powerpc: Make RTAS console init generic
  2006-08-17  3:27   ` Michael Neuling
@ 2006-08-17  3:45     ` Michael Ellerman
  2006-08-17  4:02       ` Michael Neuling
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Ellerman @ 2006-08-17  3:45 UTC (permalink / raw)
  To: Michael Neuling; +Cc: linuxppc-dev, paulus, anton

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

On Wed, 2006-08-16 at 22:27 -0500, Michael Neuling wrote:
> > Seems to work fine on Cell.
> 
> Kewl
> 
> > > Updated Kconfig so we can enable it. 
> > 
> > I enable it via the early debugging menu (under kernel hacking), is that
> > not good enough?
> 
> Doesn't that enable CONFIG_PPC_EARLY_DEBUG_RTAS_CONSOLE not
> CONFIG_UDBG_RTAS_CONSOLE?

Yeah, but that then turns on CONFIG_UDBG_RTAS_CONSOLE also. I guess you
guys want to be able to turn on the later without the former, so fair
enough. We turn it on always on the Cell via the PPC_IBM_CELL_BLADE
entry.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] powerpc: Make RTAS console init generic
  2006-08-17  3:45     ` Michael Ellerman
@ 2006-08-17  4:02       ` Michael Neuling
  0 siblings, 0 replies; 10+ messages in thread
From: Michael Neuling @ 2006-08-17  4:02 UTC (permalink / raw)
  To: michael; +Cc: linuxppc-dev, paulus, anton

> Yeah, but that then turns on CONFIG_UDBG_RTAS_CONSOLE also. I guess
> you guys want to be able to turn on the later without the former, so
> fair enough.

Yeap.  

Mikey

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] powerpc: Make RTAS console init generic
@ 2006-08-17  4:12 Michael Neuling
  0 siblings, 0 replies; 10+ messages in thread
From: Michael Neuling @ 2006-08-17  4:12 UTC (permalink / raw)
  To: paulus; +Cc: linuxppc-dev, anton

The rtas console doesn't have to be Cell specific.  If we get both
RTAS tokens, we should just enabled the console then and there.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
Fixed RTAS dependency bug.

 arch/powerpc/Kconfig                |    3 ++-
 arch/powerpc/kernel/rtas.c          |    5 +++++
 arch/powerpc/platforms/cell/setup.c |    4 ----
 3 files changed, 7 insertions(+), 5 deletions(-)

Index: linux-2.6-ozlabs/arch/powerpc/Kconfig
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/Kconfig
+++ linux-2.6-ozlabs/arch/powerpc/Kconfig
@@ -426,7 +426,8 @@ config PPC_IBM_CELL_BLADE
 	select UDBG_RTAS_CONSOLE
 
 config UDBG_RTAS_CONSOLE
-	bool
+	bool "RTAS based debug console"
+	depends on PPC_RTAS
 	default n
 
 config XICS
Index: linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/kernel/rtas.c
+++ linux-2.6-ozlabs/arch/powerpc/kernel/rtas.c
@@ -910,6 +910,11 @@ int __init early_init_dt_scan_rtas(unsig
 	basep = of_get_flat_dt_prop(node, "get-term-char", NULL);
 	if (basep)
 		rtas_getchar_token = *basep;
+
+	if (rtas_putchar_token != RTAS_UNKNOWN_SERVICE &&
+	    rtas_getchar_token != RTAS_UNKNOWN_SERVICE)
+		udbg_init_rtas_console();
+
 #endif
 
 	/* break now */
Index: linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/platforms/cell/setup.c
+++ linux-2.6-ozlabs/arch/powerpc/platforms/cell/setup.c
@@ -150,10 +150,6 @@ static int __init cell_probe(void)
 	    !of_flat_dt_is_compatible(root, "IBM,CPBW-1.0"))
 		return 0;
 
-#ifdef CONFIG_UDBG_RTAS_CONSOLE
-	udbg_init_rtas_console();
-#endif
-
 	hpte_init_native();
 
 	return 1;

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2006-08-17  4:12 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-16 19:42 [PATCH] powerpc: Make RTAS console init generic Michael Neuling
2006-08-17  2:04 ` Michael Ellerman
2006-08-17  3:27   ` Michael Neuling
2006-08-17  3:45     ` Michael Ellerman
2006-08-17  4:02       ` Michael Neuling
  -- strict thread matches above, loose matches on Subject: below --
2006-08-17  4:12 Michael Neuling
2006-08-16  4:00 Michael Neuling
2006-08-16  5:21 ` Michael Ellerman
2006-08-16 15:22   ` Michael Neuling
2006-08-17  0:44     ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).