* Patch] Fix the mpc8641_hpcn.dts file.
@ 2006-08-17 17:24 Jon Loeliger
2006-08-17 18:51 ` Hollis Blanchard
0 siblings, 1 reply; 9+ messages in thread
From: Jon Loeliger @ 2006-08-17 17:24 UTC (permalink / raw)
To: linuxppc-dev@ozlabs.org
Add 'linux,phandle' entry to i8259@4d0 node.
Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
Signed-off-by: Jon Loeliger <jdl@freescale.com>
---
Paul,
If possible, this should be slated for the
upcoming .18 release.
Thanks,
jdl
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
index e832a88..f0c7731 100644
--- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
+++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
@@ -293,6 +293,7 @@
f800 0 0 4 4d0 0 0
>;
i8259@4d0 {
+ linux,phandle = <4d0>;
clock-frequency = <0>;
interrupt-controller;
device_type = "interrupt-controller";
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: Patch] Fix the mpc8641_hpcn.dts file.
2006-08-17 17:24 Patch] Fix the mpc8641_hpcn.dts file Jon Loeliger
@ 2006-08-17 18:51 ` Hollis Blanchard
2006-08-17 21:20 ` [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts Jon Loeliger
0 siblings, 1 reply; 9+ messages in thread
From: Hollis Blanchard @ 2006-08-17 18:51 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev@ozlabs.org
Doesn't the device tree compiler add linux,phandle properties as needed?
In this case that would be when the node is referenced by a
"<&/foo/bar/i8259@4d0>" property.
On Thu, 2006-08-17 at 12:24 -0500, Jon Loeliger wrote:
> Add 'linux,phandle' entry to i8259@4d0 node.
>
> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> Signed-off-by: Jon Loeliger <jdl@freescale.com>
> ---
>
> Paul,
>
> If possible, this should be slated for the
> upcoming .18 release.
>
> Thanks,
> jdl
>
>
> arch/powerpc/boot/dts/mpc8641_hpcn.dts | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> index e832a88..f0c7731 100644
> --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> @@ -293,6 +293,7 @@
> f800 0 0 4 4d0 0 0
> >;
> i8259@4d0 {
> + linux,phandle = <4d0>;
> clock-frequency = <0>;
> interrupt-controller;
> device_type = "interrupt-controller";
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts.
2006-08-17 18:51 ` Hollis Blanchard
@ 2006-08-17 21:20 ` Jon Loeliger
2006-08-18 0:09 ` Benjamin Herrenschmidt
2006-08-18 17:32 ` Jon Loeliger
0 siblings, 2 replies; 9+ messages in thread
From: Jon Loeliger @ 2006-08-17 21:20 UTC (permalink / raw)
To: Hollis Blanchard; +Cc: linuxppc-dev@ozlabs.org
Rather than using some hand-coded linux,phandle
node references, use DTC's direct node refs ability
and let it manage the phandle names instead.
Signed-off-by: Jon Loeliger <jdl@freescale.com>
---
On Thu, 2006-08-17 at 13:51, Hollis Blanchard wrote:
> Doesn't the device tree compiler add linux,phandle properties as needed?
> In this case that would be when the node is referenced by a
> "<&/foo/bar/i8259@4d0>" property.
>
> On Thu, 2006-08-17 at 12:24 -0500, Jon Loeliger wrote:
> > Add 'linux,phandle' entry to i8259@4d0 node.
> >
> > Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> > Signed-off-by: Jon Loeliger <jdl@freescale.com>
> > ---
Paul,
If you think this is better, please apply this patch
instead of my previous patch with the subject line:
Patch] Fix the mpc8641_hpcn.dts file.
Thanks,
jdl
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 121 ++++++++++++++++----------------
1 files changed, 60 insertions(+), 61 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
index e832a88..49d85a5 100644
--- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
+++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
@@ -32,7 +32,6 @@
bus-frequency = <0>; // From uboot
clock-frequency = <0>; // From uboot
32-bit;
- linux,boot-cpu;
};
PowerPC,8641@1 {
device_type = "cpu";
@@ -202,95 +201,95 @@
interrupt-map-mask = <f800 0 0 7>;
interrupt-map = <
/* IDSEL 0x11 */
- 8800 0 0 1 4d0 3 2
- 8800 0 0 2 4d0 4 2
- 8800 0 0 3 4d0 5 2
- 8800 0 0 4 4d0 6 2
+ 8800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 3 2
+ 8800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 4 2
+ 8800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
+ 8800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
/* IDSEL 0x12 */
- 9000 0 0 1 4d0 4 2
- 9000 0 0 2 4d0 5 2
- 9000 0 0 3 4d0 6 2
- 9000 0 0 4 4d0 3 2
+ 9000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 4 2
+ 9000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
+ 9000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
+ 9000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 3 2
/* IDSEL 0x13 */
- 9800 0 0 1 4d0 0 0
- 9800 0 0 2 4d0 0 0
- 9800 0 0 3 4d0 0 0
- 9800 0 0 4 4d0 0 0
+ 9800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ 9800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ 9800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ 9800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
/* IDSEL 0x14 */
- a000 0 0 1 4d0 0 0
- a000 0 0 2 4d0 0 0
- a000 0 0 3 4d0 0 0
- a000 0 0 4 4d0 0 0
+ a000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ a000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ a000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ a000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
/* IDSEL 0x15 */
- a800 0 0 1 4d0 0 0
- a800 0 0 2 4d0 0 0
- a800 0 0 3 4d0 0 0
- a800 0 0 4 4d0 0 0
+ a800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ a800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ a800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ a800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
/* IDSEL 0x16 */
- b000 0 0 1 4d0 0 0
- b000 0 0 2 4d0 0 0
- b000 0 0 3 4d0 0 0
- b000 0 0 4 4d0 0 0
+ b000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ b000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ b000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ b000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
/* IDSEL 0x17 */
- b800 0 0 1 4d0 0 0
- b800 0 0 2 4d0 0 0
- b800 0 0 3 4d0 0 0
- b800 0 0 4 4d0 0 0
+ b800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ b800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ b800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ b800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
/* IDSEL 0x18 */
- c000 0 0 1 4d0 0 0
- c000 0 0 2 4d0 0 0
- c000 0 0 3 4d0 0 0
- c000 0 0 4 4d0 0 0
+ c000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ c000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ c000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ c000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
/* IDSEL 0x19 */
- c800 0 0 1 4d0 0 0
- c800 0 0 2 4d0 0 0
- c800 0 0 3 4d0 0 0
- c800 0 0 4 4d0 0 0
+ c800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ c800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ c800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ c800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
/* IDSEL 0x1a */
- d000 0 0 1 4d0 6 2
- d000 0 0 2 4d0 3 2
- d000 0 0 3 4d0 4 2
- d000 0 0 4 4d0 5 2
+ d000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
+ d000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 3 2
+ d000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 4 2
+ d000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
/* IDSEL 0x1b */
- d800 0 0 1 4d0 5 2
- d800 0 0 2 4d0 0 0
- d800 0 0 3 4d0 0 0
- d800 0 0 4 4d0 0 0
+ d800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
+ d800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ d800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ d800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
/* IDSEL 0x1c */
- e000 0 0 1 4d0 9 2
- e000 0 0 2 4d0 a 2
- e000 0 0 3 4d0 c 2
- e000 0 0 4 4d0 7 2
+ e000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 9 2
+ e000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 a 2
+ e000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 c 2
+ e000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 7 2
/* IDSEL 0x1d */
- e800 0 0 1 4d0 9 2
- e800 0 0 2 4d0 a 2
- e800 0 0 3 4d0 b 2
- e800 0 0 4 4d0 0 0
+ e800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 9 2
+ e800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 a 2
+ e800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 b 2
+ e800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
/* IDSEL 0x1e */
- f000 0 0 1 4d0 c 2
- f000 0 0 2 4d0 0 0
- f000 0 0 3 4d0 0 0
- f000 0 0 4 4d0 0 0
+ f000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 c 2
+ f000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ f000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ f000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
/* IDSEL 0x1f */
- f800 0 0 1 4d0 6 2
- f800 0 0 2 4d0 0 0
- f800 0 0 3 4d0 0 0
- f800 0 0 4 4d0 0 0
+ f800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
+ f800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ f800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
+ f800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>;
i8259@4d0 {
clock-frequency = <0>;
--
2006_06_07.01.gittree_pull-dirty
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts.
2006-08-17 21:20 ` [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts Jon Loeliger
@ 2006-08-18 0:09 ` Benjamin Herrenschmidt
2006-08-18 0:43 ` Mark A. Greer
2006-08-18 17:32 ` Jon Loeliger
1 sibling, 1 reply; 9+ messages in thread
From: Benjamin Herrenschmidt @ 2006-08-18 0:09 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev@ozlabs.org
On Thu, 2006-08-17 at 16:20 -0500, Jon Loeliger wrote:
> Rather than using some hand-coded linux,phandle
> node references, use DTC's direct node refs ability
> and let it manage the phandle names instead.
Not 100% sure here but can't we use a label and do &label rather than
having to copy the full path every time ? Would make things easier :) If
not, that's probably something to add to dtc...
Cheers,
Ben.
> Signed-off-by: Jon Loeliger <jdl@freescale.com>
> ---
>
> On Thu, 2006-08-17 at 13:51, Hollis Blanchard wrote:
> > Doesn't the device tree compiler add linux,phandle properties as needed?
> > In this case that would be when the node is referenced by a
> > "<&/foo/bar/i8259@4d0>" property.
> >
> > On Thu, 2006-08-17 at 12:24 -0500, Jon Loeliger wrote:
> > > Add 'linux,phandle' entry to i8259@4d0 node.
> > >
> > > Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> > > Signed-off-by: Jon Loeliger <jdl@freescale.com>
> > > ---
>
> Paul,
>
> If you think this is better, please apply this patch
> instead of my previous patch with the subject line:
>
> Patch] Fix the mpc8641_hpcn.dts file.
>
> Thanks,
> jdl
>
>
> arch/powerpc/boot/dts/mpc8641_hpcn.dts | 121 ++++++++++++++++----------------
> 1 files changed, 60 insertions(+), 61 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> index e832a88..49d85a5 100644
> --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> @@ -32,7 +32,6 @@
> bus-frequency = <0>; // From uboot
> clock-frequency = <0>; // From uboot
> 32-bit;
> - linux,boot-cpu;
> };
> PowerPC,8641@1 {
> device_type = "cpu";
> @@ -202,95 +201,95 @@
> interrupt-map-mask = <f800 0 0 7>;
> interrupt-map = <
> /* IDSEL 0x11 */
> - 8800 0 0 1 4d0 3 2
> - 8800 0 0 2 4d0 4 2
> - 8800 0 0 3 4d0 5 2
> - 8800 0 0 4 4d0 6 2
> + 8800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 3 2
> + 8800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 4 2
> + 8800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
> + 8800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
>
> /* IDSEL 0x12 */
> - 9000 0 0 1 4d0 4 2
> - 9000 0 0 2 4d0 5 2
> - 9000 0 0 3 4d0 6 2
> - 9000 0 0 4 4d0 3 2
> + 9000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 4 2
> + 9000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
> + 9000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
> + 9000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 3 2
>
> /* IDSEL 0x13 */
> - 9800 0 0 1 4d0 0 0
> - 9800 0 0 2 4d0 0 0
> - 9800 0 0 3 4d0 0 0
> - 9800 0 0 4 4d0 0 0
> + 9800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + 9800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + 9800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + 9800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>
> /* IDSEL 0x14 */
> - a000 0 0 1 4d0 0 0
> - a000 0 0 2 4d0 0 0
> - a000 0 0 3 4d0 0 0
> - a000 0 0 4 4d0 0 0
> + a000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + a000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + a000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + a000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>
> /* IDSEL 0x15 */
> - a800 0 0 1 4d0 0 0
> - a800 0 0 2 4d0 0 0
> - a800 0 0 3 4d0 0 0
> - a800 0 0 4 4d0 0 0
> + a800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + a800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + a800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + a800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>
> /* IDSEL 0x16 */
> - b000 0 0 1 4d0 0 0
> - b000 0 0 2 4d0 0 0
> - b000 0 0 3 4d0 0 0
> - b000 0 0 4 4d0 0 0
> + b000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + b000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + b000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + b000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>
> /* IDSEL 0x17 */
> - b800 0 0 1 4d0 0 0
> - b800 0 0 2 4d0 0 0
> - b800 0 0 3 4d0 0 0
> - b800 0 0 4 4d0 0 0
> + b800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + b800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + b800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + b800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>
> /* IDSEL 0x18 */
> - c000 0 0 1 4d0 0 0
> - c000 0 0 2 4d0 0 0
> - c000 0 0 3 4d0 0 0
> - c000 0 0 4 4d0 0 0
> + c000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + c000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + c000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + c000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>
> /* IDSEL 0x19 */
> - c800 0 0 1 4d0 0 0
> - c800 0 0 2 4d0 0 0
> - c800 0 0 3 4d0 0 0
> - c800 0 0 4 4d0 0 0
> + c800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + c800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + c800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + c800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>
> /* IDSEL 0x1a */
> - d000 0 0 1 4d0 6 2
> - d000 0 0 2 4d0 3 2
> - d000 0 0 3 4d0 4 2
> - d000 0 0 4 4d0 5 2
> + d000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
> + d000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 3 2
> + d000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 4 2
> + d000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
>
>
> /* IDSEL 0x1b */
> - d800 0 0 1 4d0 5 2
> - d800 0 0 2 4d0 0 0
> - d800 0 0 3 4d0 0 0
> - d800 0 0 4 4d0 0 0
> + d800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
> + d800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + d800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + d800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>
> /* IDSEL 0x1c */
> - e000 0 0 1 4d0 9 2
> - e000 0 0 2 4d0 a 2
> - e000 0 0 3 4d0 c 2
> - e000 0 0 4 4d0 7 2
> + e000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 9 2
> + e000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 a 2
> + e000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 c 2
> + e000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 7 2
>
> /* IDSEL 0x1d */
> - e800 0 0 1 4d0 9 2
> - e800 0 0 2 4d0 a 2
> - e800 0 0 3 4d0 b 2
> - e800 0 0 4 4d0 0 0
> + e800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 9 2
> + e800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 a 2
> + e800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 b 2
> + e800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>
> /* IDSEL 0x1e */
> - f000 0 0 1 4d0 c 2
> - f000 0 0 2 4d0 0 0
> - f000 0 0 3 4d0 0 0
> - f000 0 0 4 4d0 0 0
> + f000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 c 2
> + f000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + f000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + f000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>
> /* IDSEL 0x1f */
> - f800 0 0 1 4d0 6 2
> - f800 0 0 2 4d0 0 0
> - f800 0 0 3 4d0 0 0
> - f800 0 0 4 4d0 0 0
> + f800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
> + f800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + f800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> + f800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> >;
> i8259@4d0 {
> clock-frequency = <0>;
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts.
2006-08-18 0:09 ` Benjamin Herrenschmidt
@ 2006-08-18 0:43 ` Mark A. Greer
2006-08-18 1:59 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 9+ messages in thread
From: Mark A. Greer @ 2006-08-18 0:43 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev@ozlabs.org
On Fri, Aug 18, 2006 at 10:09:21AM +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2006-08-17 at 16:20 -0500, Jon Loeliger wrote:
> > Rather than using some hand-coded linux,phandle
> > node references, use DTC's direct node refs ability
> > and let it manage the phandle names instead.
>
> Not 100% sure here but can't we use a label and do &label rather than
> having to copy the full path every time ? Would make things easier :) If
> not, that's probably something to add to dtc...
Isn't linux,phandle basically the label that you speak of, though?
IOW, you may be saying, "No, keep using the linux,phandle".
Just trying to clarify things although I'm not sure that I really am... :)
Mark
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts.
2006-08-18 0:43 ` Mark A. Greer
@ 2006-08-18 1:59 ` Benjamin Herrenschmidt
2006-08-18 5:54 ` Zhang Wei-r63237
0 siblings, 1 reply; 9+ messages in thread
From: Benjamin Herrenschmidt @ 2006-08-18 1:59 UTC (permalink / raw)
To: Mark A. Greer; +Cc: linuxppc-dev@ozlabs.org
On Thu, 2006-08-17 at 17:43 -0700, Mark A. Greer wrote:
> On Fri, Aug 18, 2006 at 10:09:21AM +1000, Benjamin Herrenschmidt wrote:
> > On Thu, 2006-08-17 at 16:20 -0500, Jon Loeliger wrote:
> > > Rather than using some hand-coded linux,phandle
> > > node references, use DTC's direct node refs ability
> > > and let it manage the phandle names instead.
> >
> > Not 100% sure here but can't we use a label and do &label rather than
> > having to copy the full path every time ? Would make things easier :) If
> > not, that's probably something to add to dtc...
>
> Isn't linux,phandle basically the label that you speak of, though?
> IOW, you may be saying, "No, keep using the linux,phandle".
No, more something like
pic:
<pic_node>
and later
&pic
> Just trying to clarify things although I'm not sure that I really am... :)
>
> Mark
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts.
2006-08-18 1:59 ` Benjamin Herrenschmidt
@ 2006-08-18 5:54 ` Zhang Wei-r63237
2006-08-18 7:21 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 9+ messages in thread
From: Zhang Wei-r63237 @ 2006-08-18 5:54 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Mark A. Greer; +Cc: linuxppc-dev
Is it a good idea? Why we can not endure the "linux,phandle =3D <4d0>" =
in
i8259 node? And besides, this node was already referenced by the other
entries.
Using "&/soc8641@f8000000/pci@8000/i8259@4d0" or label seems so verbose
and weird.
> -----Original Message-----
> From: linuxppc-dev-bounces+wei.zhang=3Dfreescale.com@ozlabs.org=20
> [mailto:linuxppc-dev-bounces+wei.zhang=3Dfreescale.com@ozlabs.or
> g] On Behalf Of Benjamin Herrenschmidt
> Sent: Friday, August 18, 2006 10:00 AM
> To: Mark A. Greer
> Cc: linuxppc-dev@ozlabs.org
> Subject: Re: [PATCH] Directly reference i8259@4d0 nodes in=20
> mpc8641_hpcn.dts.
>=20
> On Thu, 2006-08-17 at 17:43 -0700, Mark A. Greer wrote:
> > On Fri, Aug 18, 2006 at 10:09:21AM +1000, Benjamin=20
> Herrenschmidt wrote:
> > > On Thu, 2006-08-17 at 16:20 -0500, Jon Loeliger wrote:
> > > > Rather than using some hand-coded linux,phandle
> > > > node references, use DTC's direct node refs ability
> > > > and let it manage the phandle names instead.
> > >=20
> > > Not 100% sure here but can't we use a label and do &label=20
> rather than
> > > having to copy the full path every time ? Would make=20
> things easier :) If
> > > not, that's probably something to add to dtc...
> >=20
> > Isn't linux,phandle basically the label that you speak of, though?
> > IOW, you may be saying, "No, keep using the linux,phandle".
>=20
> No, more something like
>=20
> pic:
> <pic_node>
>=20
> and later
>=20
> &pic
>=20
> > Just trying to clarify things although I'm not sure that I=20
> really am... :)
> >=20
> > Mark
>=20
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>=20
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts.
2006-08-18 5:54 ` Zhang Wei-r63237
@ 2006-08-18 7:21 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 9+ messages in thread
From: Benjamin Herrenschmidt @ 2006-08-18 7:21 UTC (permalink / raw)
To: Zhang Wei-r63237; +Cc: linuxppc-dev
On Fri, 2006-08-18 at 13:54 +0800, Zhang Wei-r63237 wrote:
> Is it a good idea? Why we can not endure the "linux,phandle = <4d0>" in
> i8259 node? And besides, this node was already referenced by the other
> entries.
Because magic numbers are evil and nice names are better ? :)
> Using "&/soc8641@f8000000/pci@8000/i8259@4d0" or label seems so verbose
> and weird.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts.
2006-08-17 21:20 ` [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts Jon Loeliger
2006-08-18 0:09 ` Benjamin Herrenschmidt
@ 2006-08-18 17:32 ` Jon Loeliger
1 sibling, 0 replies; 9+ messages in thread
From: Jon Loeliger @ 2006-08-18 17:32 UTC (permalink / raw)
To: linuxppc-dev@ozlabs.org
On Thu, 2006-08-17 at 16:20, Jon Loeliger wrote:
> Rather than using some hand-coded linux,phandle
> node references, use DTC's direct node refs ability
> and let it manage the phandle names instead.
>
> Signed-off-by: Jon Loeliger <jdl@freescale.com>
> ---
>
> On Thu, 2006-08-17 at 13:51, Hollis Blanchard wrote:
> > Doesn't the device tree compiler add linux,phandle properties as needed?
> > In this case that would be when the node is referenced by a
> > "<&/foo/bar/i8259@4d0>" property.
> >
> > On Thu, 2006-08-17 at 12:24 -0500, Jon Loeliger wrote:
> > > Add 'linux,phandle' entry to i8259@4d0 node.
> > >
> > > Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> > > Signed-off-by: Jon Loeliger <jdl@freescale.com>
> > > ---
>
> Paul,
>
> If you think this is better, please apply this patch
> instead of my previous patch with the subject line:
>
> Patch] Fix the mpc8641_hpcn.dts file.
>
> Thanks,
> jdl
Paul,
I'll take the application of the original patch,
Fix the mpc8641_hpcn.dts file.
as an indication that this, alternate version should
now be simply dropped!
Thanks,
jdl
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2006-08-18 17:38 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-17 17:24 Patch] Fix the mpc8641_hpcn.dts file Jon Loeliger
2006-08-17 18:51 ` Hollis Blanchard
2006-08-17 21:20 ` [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts Jon Loeliger
2006-08-18 0:09 ` Benjamin Herrenschmidt
2006-08-18 0:43 ` Mark A. Greer
2006-08-18 1:59 ` Benjamin Herrenschmidt
2006-08-18 5:54 ` Zhang Wei-r63237
2006-08-18 7:21 ` Benjamin Herrenschmidt
2006-08-18 17:32 ` Jon Loeliger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).