linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jon Loeliger <jdl@freescale.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts.
Date: Fri, 18 Aug 2006 10:09:21 +1000	[thread overview]
Message-ID: <1155859761.5803.6.camel@localhost.localdomain> (raw)
In-Reply-To: <1155849609.10054.175.camel@cashmere.sps.mot.com>

On Thu, 2006-08-17 at 16:20 -0500, Jon Loeliger wrote:
> Rather than using some hand-coded linux,phandle
> node references, use DTC's direct node refs ability
> and let it manage the phandle names instead.

Not 100% sure here but can't we use a label and do &label rather than
having to copy the full path every time ? Would make things easier :) If
not, that's probably something to add to dtc...

Cheers,
Ben.

> Signed-off-by: Jon Loeliger <jdl@freescale.com>
> ---
> 
> On Thu, 2006-08-17 at 13:51, Hollis Blanchard wrote:
> > Doesn't the device tree compiler add linux,phandle properties as needed?
> > In this case that would be when the node is referenced by a
> > "<&/foo/bar/i8259@4d0>" property.
> > 
> > On Thu, 2006-08-17 at 12:24 -0500, Jon Loeliger wrote:
> > > Add 'linux,phandle' entry to i8259@4d0 node.
> > > 
> > > Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> > > Signed-off-by: Jon Loeliger <jdl@freescale.com>
> > > ---
> 
> Paul,
> 
> If you think this is better, please apply this patch
> instead of my previous patch with the subject line:
> 
>     Patch] Fix the mpc8641_hpcn.dts file.
> 
> Thanks,
> jdl
> 
> 
>  arch/powerpc/boot/dts/mpc8641_hpcn.dts |  121 ++++++++++++++++----------------
>  1 files changed, 60 insertions(+), 61 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> index e832a88..49d85a5 100644
> --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> @@ -32,7 +32,6 @@
>  			bus-frequency = <0>;		// From uboot
>  			clock-frequency = <0>;		// From uboot
>  			32-bit;
> -			linux,boot-cpu;
>  		};
>  		PowerPC,8641@1 {
>  			device_type = "cpu";
> @@ -202,95 +201,95 @@
>  			interrupt-map-mask = <f800 0 0 7>;
>  			interrupt-map = <
>  				/* IDSEL 0x11 */
> -				8800 0 0 1 4d0 3 2
> -				8800 0 0 2 4d0 4 2
> -				8800 0 0 3 4d0 5 2
> -				8800 0 0 4 4d0 6 2
> +				8800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 3 2
> +				8800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 4 2
> +				8800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
> +				8800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
>  
>  				/* IDSEL 0x12 */
> -				9000 0 0 1 4d0 4 2
> -				9000 0 0 2 4d0 5 2
> -				9000 0 0 3 4d0 6 2
> -				9000 0 0 4 4d0 3 2
> +				9000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 4 2
> +				9000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
> +				9000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
> +				9000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 3 2
>  
>  				/* IDSEL 0x13 */
> -				9800 0 0 1 4d0 0 0
> -				9800 0 0 2 4d0 0 0
> -				9800 0 0 3 4d0 0 0
> -				9800 0 0 4 4d0 0 0
> +				9800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				9800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				9800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				9800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  
>  				/* IDSEL 0x14 */
> -				a000 0 0 1 4d0 0 0
> -				a000 0 0 2 4d0 0 0
> -				a000 0 0 3 4d0 0 0
> -				a000 0 0 4 4d0 0 0
> +				a000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				a000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				a000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				a000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  
>  				/* IDSEL 0x15 */
> -				a800 0 0 1 4d0 0 0
> -				a800 0 0 2 4d0 0 0
> -				a800 0 0 3 4d0 0 0
> -				a800 0 0 4 4d0 0 0
> +				a800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				a800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				a800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				a800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  
>  				/* IDSEL 0x16 */
> -				b000 0 0 1 4d0 0 0
> -				b000 0 0 2 4d0 0 0
> -				b000 0 0 3 4d0 0 0
> -				b000 0 0 4 4d0 0 0
> +				b000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				b000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				b000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				b000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  
>  				/* IDSEL 0x17 */
> -				b800 0 0 1 4d0 0 0
> -				b800 0 0 2 4d0 0 0
> -				b800 0 0 3 4d0 0 0
> -				b800 0 0 4 4d0 0 0
> +				b800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				b800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				b800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				b800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  
>  				/* IDSEL 0x18 */
> -				c000 0 0 1 4d0 0 0
> -				c000 0 0 2 4d0 0 0
> -				c000 0 0 3 4d0 0 0
> -				c000 0 0 4 4d0 0 0
> +				c000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				c000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				c000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				c000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  
>  				/* IDSEL 0x19 */
> -				c800 0 0 1 4d0 0 0
> -				c800 0 0 2 4d0 0 0
> -				c800 0 0 3 4d0 0 0
> -				c800 0 0 4 4d0 0 0
> +				c800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				c800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				c800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				c800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  
>  				/* IDSEL 0x1a */
> -				d000 0 0 1 4d0 6 2
> -				d000 0 0 2 4d0 3 2
> -				d000 0 0 3 4d0 4 2
> -				d000 0 0 4 4d0 5 2
> +				d000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
> +				d000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 3 2
> +				d000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 4 2
> +				d000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
>  
> 
>  				/* IDSEL 0x1b */
> -				d800 0 0 1 4d0 5 2
> -				d800 0 0 2 4d0 0 0
> -				d800 0 0 3 4d0 0 0
> -				d800 0 0 4 4d0 0 0
> +				d800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 5 2
> +				d800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				d800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				d800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  
>  				/* IDSEL 0x1c */
> -				e000 0 0 1 4d0 9 2
> -				e000 0 0 2 4d0 a 2
> -				e000 0 0 3 4d0 c 2
> -				e000 0 0 4 4d0 7 2
> +				e000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 9 2
> +				e000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 a 2
> +				e000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 c 2
> +				e000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 7 2
>  
>  				/* IDSEL 0x1d */
> -				e800 0 0 1 4d0 9 2
> -				e800 0 0 2 4d0 a 2
> -				e800 0 0 3 4d0 b 2
> -				e800 0 0 4 4d0 0 0
> +				e800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 9 2
> +				e800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 a 2
> +				e800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 b 2
> +				e800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  
>  				/* IDSEL 0x1e */
> -				f000 0 0 1 4d0 c 2
> -				f000 0 0 2 4d0 0 0
> -				f000 0 0 3 4d0 0 0
> -				f000 0 0 4 4d0 0 0
> +				f000 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 c 2
> +				f000 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				f000 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				f000 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  
>  				/* IDSEL 0x1f */
> -				f800 0 0 1 4d0 6 2
> -				f800 0 0 2 4d0 0 0
> -				f800 0 0 3 4d0 0 0
> -				f800 0 0 4 4d0 0 0
> +				f800 0 0 1 &/soc8641@f8000000/pci@8000/i8259@4d0 6 2
> +				f800 0 0 2 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				f800 0 0 3 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
> +				f800 0 0 4 &/soc8641@f8000000/pci@8000/i8259@4d0 0 0
>  				>;
>  			i8259@4d0 {
>  				clock-frequency = <0>;

  reply	other threads:[~2006-08-18  0:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-17 17:24 Patch] Fix the mpc8641_hpcn.dts file Jon Loeliger
2006-08-17 18:51 ` Hollis Blanchard
2006-08-17 21:20   ` [PATCH] Directly reference i8259@4d0 nodes in mpc8641_hpcn.dts Jon Loeliger
2006-08-18  0:09     ` Benjamin Herrenschmidt [this message]
2006-08-18  0:43       ` Mark A. Greer
2006-08-18  1:59         ` Benjamin Herrenschmidt
2006-08-18  5:54           ` Zhang Wei-r63237
2006-08-18  7:21             ` Benjamin Herrenschmidt
2006-08-18 17:32     ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1155859761.5803.6.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=jdl@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).