From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vms046pub.verizon.net (vms046pub.verizon.net [206.46.252.46]) by ozlabs.org (Postfix) with ESMTP id 2E83967A3D for ; Sat, 19 Aug 2006 17:48:43 +1000 (EST) Received: from andyhp.tranquilitynj.net ([70.21.171.40]) by vms046.mailsrvcs.net (Sun Java System Messaging Server 6.2-4.02 (built Sep 9 2005)) with ESMTPA id <0J4800IPFG91B493@vms046.mailsrvcs.net> for linuxppc-dev@ozlabs.org; Sat, 19 Aug 2006 01:48:38 -0500 (CDT) Date: Sat, 19 Aug 2006 02:48:32 -0400 From: Andy Gay Subject: Re: [2.6.19 PATCH 4/7] ehea: ethtool interface In-reply-to: <1155968305.1388.4.camel@localhost.localdomain> To: michael@ellerman.id.au Message-id: <1155970112.7302.434.camel@tahini.andynet.net> MIME-version: 1.0 Content-type: text/plain References: <200608181333.23031.ossthema@de.ibm.com> <20060818140506.GC5201@martell.zuzino.mipt.ru> <44E5DFA6.7040707@de.ibm.com> <1155968305.1388.4.camel@localhost.localdomain> Cc: Thomas Klein , Jan-Bernd Themann , netdev@vger.kernel.org, linux-kernel , Thomas Klein , linux-ppc , Christoph Raisch , Marcus Eder , Alexey Dobriyan List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 2006-08-19 at 16:18 +1000, Michael Ellerman wrote: > > If you try to return an uninitialized value the compiler will warn you, > you'll then look at the code and realise you missed a case, you might > save yourself a bug. You *should* look at the code :) So should we be reporting these as bugs? andy@cx02:~/linux/linux-2.6.17.6$ script make.script Script started, file is make.script andy@cx02:~/linux/linux-2.6.17.6$ make ... Script done, file is make.script andy@cx02:~/linux/linux-2.6.17.6$ fgrep warning make.script arch/i386/kernel/cpu/transmeta.c:12: warning: 'cpu_freq' may be used uninitialized in this function fs/bio.c:169: warning: 'idx' may be used uninitialized in this function fs/eventpoll.c:500: warning: 'fd' may be used uninitialized in this function fs/isofs/namei.c:162: warning: 'offset' may be used uninitialized in this function fs/isofs/namei.c:162: warning: 'block' may be used uninitialized in this function fs/nfsd/nfsctl.c:292: warning: 'maxsize' may be used uninitialized in this function fs/udf/balloc.c:751: warning: 'goal_eloc.logicalBlockNum' may be used uninitialized in this function fs/udf/super.c:1358: warning: 'ino.partitionReferenceNum' may be used uninitialized in this function fs/xfs/xfs_alloc_btree.c:611: warning: 'nkey.ar_startblock' may be used uninitialized in this function fs/xfs/xfs_alloc_btree.c:611: warning: 'nkey.ar_blockcount' may be used uninitialized in this function fs/xfs/xfs_bmap.c:2498: warning: 'rtx' is used uninitialized in this function fs/xfs/xfs_bmap_btree.c:753: warning: 'nkey.br_startoff' may be used uninitialized in this function fs/xfs/xfs_da_btree.c:151: warning: 'action' may be used uninitialized in this function fs/xfs/xfs_dir.c:363: warning: 'totallen' may be used uninitialized in this function fs/xfs/xfs_dir.c:363: warning: 'count' may be used uninitialized in this function fs/xfs/xfs_ialloc_btree.c:545: warning: 'nkey.ir_startino' may be used uninitialized in this function fs/xfs/xfs_inode.c:1958: warning: 'last_dip' may be used uninitialized in this function fs/xfs/xfs_inode.c:1960: warning: 'last_offset' may be used uninitialized in this function fs/xfs/xfs_log.c:1749: warning: 'iclog' may be used uninitialized in this function fs/xfs/xfs_log_recover.c:523: warning: 'first_blk' may be used uninitialized in this function ipc/msg.c:338: warning: 'setbuf.qbytes' may be used uninitialized in this function ipc/msg.c:338: warning: 'setbuf.uid' may be used uninitialized in this function ipc/msg.c:338: warning: 'setbuf.gid' may be used uninitialized in this function ipc/msg.c:338: warning: 'setbuf.mode' may be used uninitialized in this function ipc/sem.c:810: warning: 'setbuf.uid' may be used uninitialized in this function ipc/sem.c:810: warning: 'setbuf.gid' may be used uninitialized in this function ipc/sem.c:810: warning: 'setbuf.mode' may be used uninitialized in this function drivers/md/dm-table.c:431: warning: 'dev' may be used uninitialized in this function drivers/md/dm-ioctl.c:1388: warning: 'param' may be used uninitialized in this function net/sched/sch_cbq.c:409: warning: 'ret' may be used uninitialized in this function lib/zlib_inflate/inftrees.c:121: warning: 'r.base' may be used uninitialized in this function