[PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Zang Roy-r61911]

The patch passes the UPIO_TSI flag to general 8259 serial driver

Signed-off-by: Roy Zang	<tie-fei.zang@freescale.com>=20

---
 arch/powerpc/kernel/legacy_serial.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/legacy_serial.c
b/arch/powerpc/kernel/legacy_serial.c
index 359ab89..07c2c00 100644
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -115,6 +115,7 @@ static int __init add_legacy_soc_port(st
 	u64 addr;
 	u32 *addrp;
 	upf_t flags =3D UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_SHARE_IRQ;
+	struct device_node *tsi =3D of_get_parent(np);
=20
 	/* We only support ports that have a clock frequency properly
 	 * encoded in the device-tree.
@@ -134,7 +135,10 @@ static int __init add_legacy_soc_port(st
 	/* Add port, irq will be dealt with later. We passed a
translated
 	 * IO port value. It will be fixed up later along with the irq
 	 */
-	return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ,
flags, 0);
+	if (tsi && !strcmp(tsi->type, "tsi-bridge"))
+		return add_legacy_port(np, -1, UPIO_TSI, addr, addr,
NO_IRQ, flags, 0);
+	else=20
+		return add_legacy_port(np, -1, UPIO_MEM, addr, addr,
NO_IRQ, flags, 0);
 }
=20
 static int __init add_legacy_isa_port(struct device_node *np,
@@ -464,7 +468,7 @@ static int __init serial_dev_init(void)
 			fixup_port_irq(i, np, port);
 		if (port->iotype =3D=3D UPIO_PORT)
 			fixup_port_pio(i, np, port);
-		if (port->iotype =3D=3D UPIO_MEM)
+		if ((port->iotype =3D=3D UPIO_MEM) || (port->iotype =3D=3D
UPIO_TSI))
 			fixup_port_mmio(i, np, port);
 	}
=20
--=20
1.4.0

Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Benjamin Herrenschmidt]

On Wed, 2006-08-23 at 10:20 +0800, Zang Roy-r61911 wrote:
> The patch passes the UPIO_TSI flag to general 8259 serial driver

Patch looks damaged to me... appart from that, what it does looks ok to
me.

> Signed-off-by: Roy Zang	<tie-fei.zang@freescale.com> 
> 
> ---
>  arch/powerpc/kernel/legacy_serial.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/legacy_serial.c
> b/arch/powerpc/kernel/legacy_serial.c
> index 359ab89..07c2c00 100644
> --- a/arch/powerpc/kernel/legacy_serial.c
> +++ b/arch/powerpc/kernel/legacy_serial.c
> @@ -115,6 +115,7 @@ static int __init add_legacy_soc_port(st
>  	u64 addr;
>  	u32 *addrp;
>  	upf_t flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_SHARE_IRQ;
> +	struct device_node *tsi = of_get_parent(np);
>  
>  	/* We only support ports that have a clock frequency properly
>  	 * encoded in the device-tree.
> @@ -134,7 +135,10 @@ static int __init add_legacy_soc_port(st
>  	/* Add port, irq will be dealt with later. We passed a
> translated
>  	 * IO port value. It will be fixed up later along with the irq
>  	 */
> -	return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ,
> flags, 0);
> +	if (tsi && !strcmp(tsi->type, "tsi-bridge"))
> +		return add_legacy_port(np, -1, UPIO_TSI, addr, addr,
> NO_IRQ, flags, 0);
> +	else 
> +		return add_legacy_port(np, -1, UPIO_MEM, addr, addr,
> NO_IRQ, flags, 0);
>  }
>  
>  static int __init add_legacy_isa_port(struct device_node *np,
> @@ -464,7 +468,7 @@ static int __init serial_dev_init(void)
>  			fixup_port_irq(i, np, port);
>  		if (port->iotype == UPIO_PORT)
>  			fixup_port_pio(i, np, port);
> -		if (port->iotype == UPIO_MEM)
> +		if ((port->iotype == UPIO_MEM) || (port->iotype ==
> UPIO_TSI))
>  			fixup_port_mmio(i, np, port);
>  	}
>  

Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Kumar Gala]

On Aug 22, 2006, at 9:20 PM, Zang Roy-r61911 wrote:

> The patch passes the UPIO_TSI flag to general 8259 serial driver
>
> Signed-off-by: Roy Zang	<tie-fei.zang@freescale.com>

Maybe, I'm missing something, but why do we need this?  Why doesn't  
iotype == UPIO_MEM work for the TSI?

- kumar

>
> ---
>  arch/powerpc/kernel/legacy_serial.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/legacy_serial.c
> b/arch/powerpc/kernel/legacy_serial.c
> index 359ab89..07c2c00 100644
> --- a/arch/powerpc/kernel/legacy_serial.c
> +++ b/arch/powerpc/kernel/legacy_serial.c
> @@ -115,6 +115,7 @@ static int __init add_legacy_soc_port(st
>  	u64 addr;
>  	u32 *addrp;
>  	upf_t flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_SHARE_IRQ;
> +	struct device_node *tsi = of_get_parent(np);
>
>  	/* We only support ports that have a clock frequency properly
>  	 * encoded in the device-tree.
> @@ -134,7 +135,10 @@ static int __init add_legacy_soc_port(st
>  	/* Add port, irq will be dealt with later. We passed a
> translated
>  	 * IO port value. It will be fixed up later along with the irq
>  	 */
> -	return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ,
> flags, 0);
> +	if (tsi && !strcmp(tsi->type, "tsi-bridge"))
> +		return add_legacy_port(np, -1, UPIO_TSI, addr, addr,
> NO_IRQ, flags, 0);
> +	else
> +		return add_legacy_port(np, -1, UPIO_MEM, addr, addr,
> NO_IRQ, flags, 0);
>  }
>
>  static int __init add_legacy_isa_port(struct device_node *np,
> @@ -464,7 +468,7 @@ static int __init serial_dev_init(void)
>  			fixup_port_irq(i, np, port);
>  		if (port->iotype == UPIO_PORT)
>  			fixup_port_pio(i, np, port);
> -		if (port->iotype == UPIO_MEM)
> +		if ((port->iotype == UPIO_MEM) || (port->iotype ==
> UPIO_TSI))
>  			fixup_port_mmio(i, np, port);
>  	}
>
> -- 
> 1.4.0
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Paul Mackerras]

Kumar Gala writes:

> Maybe, I'm missing something, but why do we need this?  Why doesn't  
> iotype == UPIO_MEM work for the TSI?

It seems that there are some workarounds for TSI "features" in
drivers/serial/8250.c that this will invoke.

Paul.

RE: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Zang Roy-r61911]

>=20
> On Aug 22, 2006, at 9:20 PM, Zang Roy-r61911 wrote:
>=20
> > The patch passes the UPIO_TSI flag to general 8259 serial driver
> >
> > Signed-off-by: Roy Zang	<tie-fei.zang@freescale.com>
>=20
> Maybe, I'm missing something, but why do we need this?  Why=20
> doesn't iotype =3D=3D UPIO_MEM work for the TSI?
>=20
> - kumar
>=20

Tsi108 serial port has some difference from the standard 8250 port.
 I add UPIO_TSI in general 8250 serial driver to handle IIR and IER
register=20
in serial_in and serial_out.

(1) the reason to rewrite serial_in:

    TSI108 rev Z1 version ERRATA.  Reading the UART's Interrupt
    Identification Register (IIR) clears the Transmit Holding Register
    Empty (THRE) and Transmit buffer Empty (TEMP) interrupts even if
they
    are not enabled in the Interrupt Enable Register (IER).  This leads
to
    loss of the interrupts.  Interrupts are not cleared when reading
UART
    registers as 32-bit word.

(2) the reason to rewrite serial_out:

    Check for UART_IER_UUE bit in the autoconfig routine.  This section
    of autoconfig is excluded for Tsi108/109 because bits 7 and 6 are
    reserved for internal use.  They are R/W bits.  In addition to
    incorrect identification, changing these bits (from 00) will make
    Tsi108/109 UART non-functional.

I need to pass UPIO_TSI flag to the 8250 driver when the tsi108 bridge
serial port is used.

Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Kumar Gala]

On Aug 23, 2006, at 1:27 AM, Zang Roy-r61911 wrote:

>>
>> On Aug 22, 2006, at 9:20 PM, Zang Roy-r61911 wrote:
>>
>>> The patch passes the UPIO_TSI flag to general 8259 serial driver
>>>
>>> Signed-off-by: Roy Zang	<tie-fei.zang@freescale.com>
>>
>> Maybe, I'm missing something, but why do we need this?  Why
>> doesn't iotype == UPIO_MEM work for the TSI?
>>
>> - kumar
>>
>
> Tsi108 serial port has some difference from the standard 8250 port.
>  I add UPIO_TSI in general 8250 serial driver to handle IIR and IER
> register
> in serial_in and serial_out.

Gotcha, that makes sense now.

- k

Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Zang Roy-r61911]

Benjamin Herrenschmidt wrote:
> On Wed, 2006-08-23 at 10:20 +0800, Zang Roy-r61911 wrote:
>   
>> The patch passes the UPIO_TSI flag to general 8259 serial driver
>>     
>
> Patch looks damaged to me... appart from that, what it does looks ok to
> me.
Sorry. It seems imported by my mail client. Please pick up the following 
one.

Signed-off-by: Roy Zang	<tie-fei.zang@freescale.com>

 ---

 arch/powerpc/kernel/legacy_serial.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/legacy_serial.c 
b/arch/powerpc/kernel/legacy_serial.c
index 359ab89..07c2c00 100644
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -115,6 +115,7 @@ static int __init add_legacy_soc_port(st
     u64 addr;
     u32 *addrp;
     upf_t flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_SHARE_IRQ;
+    struct device_node *tsi = of_get_parent(np);
 
     /* We only support ports that have a clock frequency properly
      * encoded in the device-tree.
@@ -134,7 +135,10 @@ static int __init add_legacy_soc_port(st
     /* Add port, irq will be dealt with later. We passed a translated
      * IO port value. It will be fixed up later along with the irq
      */
-    return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0);
+    if (tsi && !strcmp(tsi->type, "tsi-bridge"))
+        return add_legacy_port(np, -1, UPIO_TSI, addr, addr, NO_IRQ, 
flags, 0);
+    else
+        return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, 
flags, 0);
 }
 
 static int __init add_legacy_isa_port(struct device_node *np,
@@ -464,7 +468,7 @@ static int __init serial_dev_init(void)
             fixup_port_irq(i, np, port);
         if (port->iotype == UPIO_PORT)
             fixup_port_pio(i, np, port);
-        if (port->iotype == UPIO_MEM)
+        if ((port->iotype == UPIO_MEM) || (port->iotype == UPIO_TSI))
             fixup_port_mmio(i, np, port);
     }
 
-- 
1.4.0

Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Paul Mackerras]

Zang Roy-r61911 writes:

> Sorry. It seems imported by my mail client. Please pick up the following 
> one.

Still busted, but don't worry, I fixed it up by hand.

Paul.

Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Benjamin Herrenschmidt]

On Wed, 2006-08-23 at 16:45 +0800, Zang Roy-r61911 wrote:
> Benjamin Herrenschmidt wrote:
> > On Wed, 2006-08-23 at 10:20 +0800, Zang Roy-r61911 wrote:
> >   
> >> The patch passes the UPIO_TSI flag to general 8259 serial driver
> >>     
> >
> > Patch looks damaged to me... appart from that, what it does looks ok to
> > me.
> Sorry. It seems imported by my mail client. Please pick up the following 
> one.

Seems to be damaged as well ! What mail client do you use ? 

Ben.

> Signed-off-by: Roy Zang	<tie-fei.zang@freescale.com>
> 
>  ---
> 
>  arch/powerpc/kernel/legacy_serial.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/legacy_serial.c 
> b/arch/powerpc/kernel/legacy_serial.c
> index 359ab89..07c2c00 100644
> --- a/arch/powerpc/kernel/legacy_serial.c
> +++ b/arch/powerpc/kernel/legacy_serial.c
> @@ -115,6 +115,7 @@ static int __init add_legacy_soc_port(st
>      u64 addr;
>      u32 *addrp;
>      upf_t flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_SHARE_IRQ;
> +    struct device_node *tsi = of_get_parent(np);
>  
>      /* We only support ports that have a clock frequency properly
>       * encoded in the device-tree.
> @@ -134,7 +135,10 @@ static int __init add_legacy_soc_port(st
>      /* Add port, irq will be dealt with later. We passed a translated
>       * IO port value. It will be fixed up later along with the irq
>       */
> -    return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0);
> +    if (tsi && !strcmp(tsi->type, "tsi-bridge"))
> +        return add_legacy_port(np, -1, UPIO_TSI, addr, addr, NO_IRQ, 
> flags, 0);
> +    else
> +        return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, 
> flags, 0);
>  }
>  
>  static int __init add_legacy_isa_port(struct device_node *np,
> @@ -464,7 +468,7 @@ static int __init serial_dev_init(void)
>              fixup_port_irq(i, np, port);
>          if (port->iotype == UPIO_PORT)
>              fixup_port_pio(i, np, port);
> -        if (port->iotype == UPIO_MEM)
> +        if ((port->iotype == UPIO_MEM) || (port->iotype == UPIO_TSI))
>              fixup_port_mmio(i, np, port);
>      }
>  

Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Zang Roy-r61911]

On Thu, 2006-08-24 at 05:52, Benjamin Herrenschmidt wrote:
> On Wed, 2006-08-23 at 16:45 +0800, Zang Roy-r61911 wrote:
> > Benjamin Herrenschmidt wrote:
> > > On Wed, 2006-08-23 at 10:20 +0800, Zang Roy-r61911 wrote:
> > >   
> > >> The patch passes the UPIO_TSI flag to general 8259 serial driver
> > >>     
> > >
> > > Patch looks damaged to me... appart from that, what it does looks
> ok to
> > > me.
> > Sorry. It seems imported by my mail client. Please pick up the
> following 
> > one.
> 
> Seems to be damaged as well ! What mail client do you use ? 
> 
> Ben.
Evolution 1.2.2. I had found the reason and tested on my side.
Paul, if you do not modify it by hand, please select the following :-).
I will repost the mpic and mpc7448hph2 irq update patch.Very sorry for that.

Signed-off-by: Roy Zang       <tie-fei.zang@freescale.com> 

---
 arch/powerpc/kernel/legacy_serial.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c
index 359ab89..07c2c00 100644
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -115,6 +115,7 @@ static int __init add_legacy_soc_port(st
 	u64 addr;
 	u32 *addrp;
 	upf_t flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_SHARE_IRQ;
+	struct device_node *tsi = of_get_parent(np);
 
 	/* We only support ports that have a clock frequency properly
 	 * encoded in the device-tree.
@@ -134,7 +135,10 @@ static int __init add_legacy_soc_port(st
 	/* Add port, irq will be dealt with later. We passed a translated
 	 * IO port value. It will be fixed up later along with the irq
 	 */
-	return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0);
+	if (tsi && !strcmp(tsi->type, "tsi-bridge"))
+		return add_legacy_port(np, -1, UPIO_TSI, addr, addr, NO_IRQ, flags, 0);
+	else 
+		return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0);
 }
 
 static int __init add_legacy_isa_port(struct device_node *np,
@@ -464,7 +468,7 @@ static int __init serial_dev_init(void)
 			fixup_port_irq(i, np, port);
 		if (port->iotype == UPIO_PORT)
 			fixup_port_pio(i, np, port);
-		if (port->iotype == UPIO_MEM)
+		if ((port->iotype == UPIO_MEM) || (port->iotype == UPIO_TSI))
 			fixup_port_mmio(i, np, port);
 	}
 
-- 
1.4.0

Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Benjamin Herrenschmidt]

> Evolution 1.2.2. I had found the reason and tested on my side.
> Paul, if you do not modify it by hand, please select the following :-).
> I will repost the mpic and mpc7448hph2 irq update patch.Very sorry for that.

Ok, the trick with evolution is to use the "preformat" style.

Typically, when posting a patch, I write my description, put the caret
where I want to insert the patch itself, set the style to
"Preformat" (from the pop-up menu just above the text editing zone), and
do Insert->Text File from the menu.

You can also select a bit of text/patch and change the style to
"Preformat" afterward if you missed it before doing the import.

Ben.


> Signed-off-by: Roy Zang       <tie-fei.zang@freescale.com> 
> 
> ---
>  arch/powerpc/kernel/legacy_serial.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c
> index 359ab89..07c2c00 100644
> --- a/arch/powerpc/kernel/legacy_serial.c
> +++ b/arch/powerpc/kernel/legacy_serial.c
> @@ -115,6 +115,7 @@ static int __init add_legacy_soc_port(st
>  	u64 addr;
>  	u32 *addrp;
>  	upf_t flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_SHARE_IRQ;
> +	struct device_node *tsi = of_get_parent(np);
>  
>  	/* We only support ports that have a clock frequency properly
>  	 * encoded in the device-tree.
> @@ -134,7 +135,10 @@ static int __init add_legacy_soc_port(st
>  	/* Add port, irq will be dealt with later. We passed a translated
>  	 * IO port value. It will be fixed up later along with the irq
>  	 */
> -	return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0);
> +	if (tsi && !strcmp(tsi->type, "tsi-bridge"))
> +		return add_legacy_port(np, -1, UPIO_TSI, addr, addr, NO_IRQ, flags, 0);
> +	else 
> +		return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0);
>  }
>  
>  static int __init add_legacy_isa_port(struct device_node *np,
> @@ -464,7 +468,7 @@ static int __init serial_dev_init(void)
>  			fixup_port_irq(i, np, port);
>  		if (port->iotype == UPIO_PORT)
>  			fixup_port_pio(i, np, port);
> -		if (port->iotype == UPIO_MEM)
> +		if ((port->iotype == UPIO_MEM) || (port->iotype == UPIO_TSI))
>  			fixup_port_mmio(i, np, port);
>  	}
>  

Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Zang Roy-r61911]

On Thu, 2006-08-24 at 13:17, Benjamin Herrenschmidt wrote:
> > Evolution 1.2.2. I had found the reason and tested on my side.
> > Paul, if you do not modify it by hand, please select the following
> :-).
> > I will repost the mpic and mpc7448hph2 irq update patch.Very sorry
> for that.
> 
> Ok, the trick with evolution is to use the "preformat" style.
> 
> Typically, when posting a patch, I write my description, put the caret
> where I want to insert the patch itself, set the style to
> "Preformat" (from the pop-up menu just above the text editing zone),
> and
> do Insert->Text File from the menu.
> 
> You can also select a bit of text/patch and change the style to
> "Preformat" afterward if you missed it before doing the import.
> 
You words are  principle to post patch with evolution :-).
Roy

RE: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Li Yang-r58472]

> -----Original Message-----
> From: linuxppc-dev-bounces+leoli=3Dfreescale.com@ozlabs.org
> [mailto:linuxppc-dev-bounces+leoli=3Dfreescale.com@ozlabs.org] On =
Behalf
Of Zang
> Roy-r61911
> Sent: Thursday, August 24, 2006 1:39 PM
> To: Benjamin Herrenschmidt
> Cc: linuxppc-dev list; Paul Mackerras; Yang Xin-Xin-r48390
> Subject: Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial
driver
>=20
> On Thu, 2006-08-24 at 13:17, Benjamin Herrenschmidt wrote:
> > > Evolution 1.2.2. I had found the reason and tested on my side.
> > > Paul, if you do not modify it by hand, please select the following
> > :-).
> > > I will repost the mpic and mpc7448hph2 irq update patch.Very sorry
> > for that.
> >
> > Ok, the trick with evolution is to use the "preformat" style.
> >
> > Typically, when posting a patch, I write my description, put the
caret
> > where I want to insert the patch itself, set the style to
> > "Preformat" (from the pop-up menu just above the text editing zone),
> > and
> > do Insert->Text File from the menu.
> >
> > You can also select a bit of text/patch and change the style to
> > "Preformat" afterward if you missed it before doing the import.
> >
> You words are  principle to post patch with evolution :-).

Why did no one ever add a mail client guide to the kernel documentation?
It seems such problem happens a lot.

RE: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Zang Roy-r61911]

> > On Thu, 2006-08-24 at 13:17, Benjamin Herrenschmidt wrote:
> > > > Evolution 1.2.2. I had found the reason and tested on my side.
> > > > Paul, if you do not modify it by hand, please select=20
> the following
> > > :-).
> > > > I will repost the mpic and mpc7448hph2 irq update=20
> patch.Very sorry
> > > for that.
> > >
> > > Ok, the trick with evolution is to use the "preformat" style.
> > >
> > > Typically, when posting a patch, I write my description, put the=20
> > > caret where I want to insert the patch itself, set the style to=20
> > > "Preformat" (from the pop-up menu just above the text=20
> editing zone),=20
> > > and do Insert->Text File from the menu.
> > >
> > > You can also select a bit of text/patch and change the style to=20
> > > "Preformat" afterward if you missed it before doing the import.
> > >
> > You words are  principle to post patch with evolution :-).
>=20
> Why did no one ever add a mail client guide to the kernel=20
> documentation?  It seems such problem happens a lot.
>=20

I think there should be one in other place. But we do not know where it
is.
I have tried Thunderbird, but failed.

Roy