From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/3] Fix MPC834x SYS platform to get IRQ data from device tree and use new IRQ layer
Date: Thu, 24 Aug 2006 13:46:26 +1000 [thread overview]
Message-ID: <1156391186.8433.168.camel@localhost.localdomain> (raw)
In-Reply-To: <20060823203937.578cae45.kim.phillips@freescale.com>
> +void __init mpc83xx_pcibios_fixup(void)
> +{
> + struct pci_dev *dev = NULL;
> +
> + /* map all the PCI irqs */
> + dev = NULL;
> + for_each_pci_dev(dev)
> + pci_read_irq_line(dev);
> +}
> +
Some seriously redundant assignements above :) I'm not even sure we need
the initial assignement at all in the first place anyway.
Appart from that, looks good.
Cheers,
Ben.
prev parent reply other threads:[~2006-08-24 3:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 1:39 [PATCH 2/3] Fix MPC834x SYS platform to get IRQ data from device tree and use new IRQ layer Kim Phillips
2006-08-24 3:46 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156391186.8433.168.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=kim.phillips@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox