Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver

[Zang Roy-r61911 <tie-fei.zang@freescale.com>]

On Thu, 2006-08-24 at 05:52, Benjamin Herrenschmidt wrote:
> On Wed, 2006-08-23 at 16:45 +0800, Zang Roy-r61911 wrote:
> > Benjamin Herrenschmidt wrote:
> > > On Wed, 2006-08-23 at 10:20 +0800, Zang Roy-r61911 wrote:
> > >   
> > >> The patch passes the UPIO_TSI flag to general 8259 serial driver
> > >>     
> > >
> > > Patch looks damaged to me... appart from that, what it does looks
> ok to
> > > me.
> > Sorry. It seems imported by my mail client. Please pick up the
> following 
> > one.
> 
> Seems to be damaged as well ! What mail client do you use ? 
> 
> Ben.
Evolution 1.2.2. I had found the reason and tested on my side.
Paul, if you do not modify it by hand, please select the following :-).
I will repost the mpic and mpc7448hph2 irq update patch.Very sorry for that.

Signed-off-by: Roy Zang       <tie-fei.zang@freescale.com> 

---
 arch/powerpc/kernel/legacy_serial.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c
index 359ab89..07c2c00 100644
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -115,6 +115,7 @@ static int __init add_legacy_soc_port(st
 	u64 addr;
 	u32 *addrp;
 	upf_t flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_SHARE_IRQ;
+	struct device_node *tsi = of_get_parent(np);
 
 	/* We only support ports that have a clock frequency properly
 	 * encoded in the device-tree.
@@ -134,7 +135,10 @@ static int __init add_legacy_soc_port(st
 	/* Add port, irq will be dealt with later. We passed a translated
 	 * IO port value. It will be fixed up later along with the irq
 	 */
-	return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0);
+	if (tsi && !strcmp(tsi->type, "tsi-bridge"))
+		return add_legacy_port(np, -1, UPIO_TSI, addr, addr, NO_IRQ, flags, 0);
+	else 
+		return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0);
 }
 
 static int __init add_legacy_isa_port(struct device_node *np,
@@ -464,7 +468,7 @@ static int __init serial_dev_init(void)
 			fixup_port_irq(i, np, port);
 		if (port->iotype == UPIO_PORT)
 			fixup_port_pio(i, np, port);
-		if (port->iotype == UPIO_MEM)
+		if ((port->iotype == UPIO_MEM) || (port->iotype == UPIO_TSI))
 			fixup_port_mmio(i, np, port);
 	}
 
-- 
1.4.0