From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id B6A6367C36 for ; Thu, 24 Aug 2006 15:17:37 +1000 (EST) Subject: Re: [PATCH ] powerpc: pass UPIO_TSI flag to 8259 serial driver From: Benjamin Herrenschmidt To: Zang Roy-r61911 In-Reply-To: <1156394597.5310.42.camel@localhost.localdomain> References: <7EA18FDD2DC2154AA3BD6D2F22A62A0E26E532@zch01exm23.fsl.freescale.net> <1156304163.8433.19.camel@localhost.localdomain> <44EC15A1.4090807@freescale.com> <1156369941.8433.57.camel@localhost.localdomain> <1156394597.5310.42.camel@localhost.localdomain> Content-Type: text/plain Date: Thu, 24 Aug 2006 15:17:27 +1000 Message-Id: <1156396647.8433.184.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev list , Paul Mackerras , Yang Xin-Xin-r48390 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > Evolution 1.2.2. I had found the reason and tested on my side. > Paul, if you do not modify it by hand, please select the following :-). > I will repost the mpic and mpc7448hph2 irq update patch.Very sorry for that. Ok, the trick with evolution is to use the "preformat" style. Typically, when posting a patch, I write my description, put the caret where I want to insert the patch itself, set the style to "Preformat" (from the pop-up menu just above the text editing zone), and do Insert->Text File from the menu. You can also select a bit of text/patch and change the style to "Preformat" afterward if you missed it before doing the import. Ben. > Signed-off-by: Roy Zang > > --- > arch/powerpc/kernel/legacy_serial.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c > index 359ab89..07c2c00 100644 > --- a/arch/powerpc/kernel/legacy_serial.c > +++ b/arch/powerpc/kernel/legacy_serial.c > @@ -115,6 +115,7 @@ static int __init add_legacy_soc_port(st > u64 addr; > u32 *addrp; > upf_t flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_SHARE_IRQ; > + struct device_node *tsi = of_get_parent(np); > > /* We only support ports that have a clock frequency properly > * encoded in the device-tree. > @@ -134,7 +135,10 @@ static int __init add_legacy_soc_port(st > /* Add port, irq will be dealt with later. We passed a translated > * IO port value. It will be fixed up later along with the irq > */ > - return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0); > + if (tsi && !strcmp(tsi->type, "tsi-bridge")) > + return add_legacy_port(np, -1, UPIO_TSI, addr, addr, NO_IRQ, flags, 0); > + else > + return add_legacy_port(np, -1, UPIO_MEM, addr, addr, NO_IRQ, flags, 0); > } > > static int __init add_legacy_isa_port(struct device_node *np, > @@ -464,7 +468,7 @@ static int __init serial_dev_init(void) > fixup_port_irq(i, np, port); > if (port->iotype == UPIO_PORT) > fixup_port_pio(i, np, port); > - if (port->iotype == UPIO_MEM) > + if ((port->iotype == UPIO_MEM) || (port->iotype == UPIO_TSI)) > fixup_port_mmio(i, np, port); > } >